Re: [PATCH nf,v2 2/3] netfilter: flowtable: IPIP tunnel hardware offload is not yet support

Pablo Neira Ayuso <[email protected]> wrote:
> No driver supports for IPIP tunnels yet, give up early on setting up the
> hardware offload for this scenario.

This series triggers many drive-by findings.

No big deal, should be addressed later.

> +	__set_bit(NF_FLOW_HW, &flow->flags);

Would you mind if I mangle this to use set_bit() ?

Its a low-hanging fruit, the other findings need
more attention.

Otherwise I can also apply this as-is, its an improvement
in either case.