Re: [PATCH nf,v2 2/3] netfilter: flowtable: IPIP tunnel hardware offload is not yet support

Pablo Neira Ayuso <[email protected]>
Newsgroups gmane.comp.security.firewalls.netfilter.devel
Message-ID <akzZEhCyHWq95gGB@chamomile>
On Tue, Jul 07, 2026 at 12:31:34PM +0200, Florian Westphal wrote:
> Pablo Neira Ayuso <[email protected]> wrote:
> > No driver supports for IPIP tunnels yet, give up early on setting up the
> > hardware offload for this scenario.
> 
> This series triggers many drive-by findings.
> 
> No big deal, should be addressed later.
> 
> > +	__set_bit(NF_FLOW_HW, &flow->flags);
> 
> Would you mind if I mangle this to use set_bit() ?

Go ahead.

> Its a low-hanging fruit, the other findings need
> more attention.

Yes.

> Otherwise I can also apply this as-is, its an improvement
> in either case.

I will follow with other comments, they are pointing to relevant
issues.
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.