Re: [PATCH net 03/10] netfilter: ipset: rework cidr bookkeeping

Pablo Neira Ayuso <[email protected]> Wed, 5 Aug 2026 19:19:31 +0200
Newsgroups gmane.linux.network,gmane.comp.security.firewalls.netfilter.devel
Message-ID <anNwo7eKRm5HqOOD@chamomile>
On Tue, Aug 04, 2026 at 05:15:31PM -0700, Jakub Kicinski wrote:
> This is an AI-generated review of your patch. The human sending this
> email has considered the AI review valid, or at least plausible.
> ---
> netfilter: ipset: rework cidr bookkeeping
> 
> The prefix bookkeeping of the hash:net* set types is moved out of struct
> htype into separately allocated, RCU published struct net_prefixes arrays.
> The in-place shifting of the cidr array is replaced by allocate-copy-publish,
> with a documented fallback to leaving holes when the allocation fails.

Florian needs these starter ipset patches to follow with more fixes to
move ipset hash to use rhashtable.

For his workflow, he considers it better to do this incrementally.

While this is not perfect, we prefer this path to address the existing
issues that LLMs have reported in ipset.