Re: [PATCH net 08/10] ipvs: avoid out-of-bounds write in ip_vs_nat_icmp
Pablo Neira Ayuso <[email protected]> Wed, 5 Aug 2026 19:20:33 +0200
| Newsgroups | gmane.comp.security.firewalls.netfilter.devel,gmane.linux.network |
|---|---|
| Message-ID | <anNw4WG2wUiuatg5@chamomile> |
Hi Jakub, On Tue, Aug 04, 2026 at 05:15:34PM -0700, Jakub Kicinski wrote: > This is an AI-generated review of your patch. The human sending this > email has considered the AI review valid, or at least plausible. > --- > ipvs: avoid out-of-bounds write in ip_vs_nat_icmp > > This passes the already-parsed ip_vs_iphdr down into ip_vs_nat_icmp() so > the embedded transport header offset comes from ciph->len instead of a > second read of the inner IPv4 ihl field. The IPv4 header sanity checks in > ip_vs_out_icmp() and ip_vs_in_icmp() are also reworked to read ihl only > once. > > Link: https://sashiko.dev/#/patchset/20260722101517.36313-1-ja%40ssi.bg Julian (he's on Cc) is ready to follow to address the remaining comments mentioned here.