Re: [PATCH nf 1/7] netfilter: ipset: remove need to allocate memory on delete operations

Jozsef Kadlecsik <[email protected]> wrote:
> Sigh. It's getting more and more complicated to maintain a fairly simple 
> data structure.

Yup.  Would be very simple for SMP=n :-)

> What do you think which is better for the test (match) case (not 
> add/del), performance-wise:
> 
> - seqcount and retry
> - holes left [and INIT_CIDR() converted to a function to skip the holes
>   and find the first entry for add/del]

Depends on how likely a constant pingpong between 1 / 0 count is.  Given
data (packet) path can't insert a new netmask, I would guess its very
very unlikely, so the seqcount / retry loop is not used at all.