Re: [PATCH nf] netfilter: ipset: fix list type element drift bug
Florian Westphal <[email protected]>
| Newsgroups | gmane.comp.security.firewalls.netfilter.devel |
|---|---|
| Message-ID | <[email protected]> |
Jozsef Kadlecsik <[email protected]> wrote: > Acked-by: Jozsef Kadlecsik <[email protected]> Thanks for reviewing! > > + if (n) { > > list_set_replace(set, e, n); > > + return 0; > > + } > > + > > else if (next) > > list_add_tail_rcu(&e->list, &next->list); While it makes no difference from correctness, the above looks very weird, so I propose to turn the else if into plain if (next). (Did not spot it before sending...).