Reworking pcap__switch_to_buffer
Varunram Ganesh via dev <[email protected]>
| Newsgroups | gmane.comp.security.nmap.devel |
|---|---|
| Message-ID | <[email protected]> |
Greetings List, I was going through the source of libpcap when I came across this function call with a TODO statement [1]. It involves deleting the present body of pcap__switch_to_buffer and replacing it with calls to pcap_pop_bufffer_state and pcap_push_buffer_state. These two functions seem to handle the work of the statements currently in pcap__switch_to_buffer, so I don't find any problem with deleting them. What are your opinions on this change? [1] https://github.com/nmap/nmap/pull/871 Cheers, Varunram _______________________________________________ Sent through the dev mailing list https://nmap.org/mailman/listinfo/dev Archived at http://seclists.org/nmap-dev/