Re: Reworking pcap__switch_to_buffer

Varunram,

The libpcap code is not "ours," so we do not make or accept modifications
to it. If you want to work on this code, check out the upstream repository
[1] and make your changes to their development branch. We are currently a
version or two behind the latest release from them, so it is possible this
has already been addressed.

Dan

[1] https://github.com/the-tcpdump-group/libpcap

On Sat, Apr 29, 2017 at 5:54 AM, Varunram Ganesh <[email protected]> wrote:

> Greetings List,
>
>
> I was going through the source of libpcap when I came across this function
> call with a TODO statement [1]. It involves deleting the present body
> of pcap__switch_to_buffer and replacing it with calls to
> pcap_pop_bufffer_state and pcap_push_buffer_state. These two functions seem
> to handle the work of the statements currently in pcap__switch_to_buffer,
> so I don't find any problem with deleting them. What are your opinions on
> this change?
>
>
> [1] https://github.com/nmap/nmap/pull/871
>
>
> Cheers,
>
> Varunram
>
>
>
>

_______________________________________________
Sent through the dev mailing list
https://nmap.org/mailman/listinfo/dev
Archived at http://seclists.org/nmap-dev/