[BugFix] pcm-s5l8700 ipod nano 2g audio init hang

rockbox-gerrit-noreply--- via rockbox-cvs <[email protected]> Wed, 10 Jun 2026 00:47:57 -0400

Newsgroups	gmane.comp.systems.archos.rockbox.cvs
Message-ID	<[email protected]>

commit fee00f1f3ce6ff12258d2cf517a8d9ba498a1106
Author: William Wilgus <[email protected]>
Date:   Tue Jun 9 23:22:10 2026 -0400

    [BugFix] pcm-s5l8700 ipod nano 2g audio init hang
    
    pcm_dma_set_freq expects the frequency index not the actual frequency
    
    bug introduced in Commit dfa33c2 pcm: introduce pcm_sink
    
    Change-Id: Idc521cfe1da22b112a16f81611dac720837eeea9

diff --git a/firmware/target/arm/s5l8700/pcm-s5l8700.c b/firmware/target/arm/s5l8700/pcm-s5l8700.c
index a0d594a3f4..5bd2d4046d 100644
--- a/firmware/target/arm/s5l8700/pcm-s5l8700.c
+++ b/firmware/target/arm/s5l8700/pcm-s5l8700.c
@@ -253,9 +253,9 @@ static void sink_dma_init(void)
 }
 
 /* set the configured PCM frequency */
-static void sink_set_freq(uint16_t freq)
+static void sink_set_freq(uint16_t freq_idx)
 {
-    pcm_dma_set_freq(hw_freq_sampr[freq]);
+    pcm_dma_set_freq(freq_idx);
 }
 
 #ifdef HAVE_PCM_DMA_ADDRESS
-- 
rockbox-cvs mailing list
[email protected]
https://lists.haxx.se/mailman/listinfo/rockbox-cvs