[BugFix] prevent infinite loop to return to wps from plugins

rockbox-gerrit-noreply--- via rockbox-cvs <[email protected]> Wed, 10 Jun 2026 01:26:52 -0400
Newsgroups gmane.comp.systems.archos.rockbox.cvs
Message-ID <[email protected]>
commit 0a1858b9d12fc75b7ad65277f2b9048a9c0c96f4
Author: William Wilgus <[email protected]>
Date:   Wed Jun 10 01:14:53 2026 -0400

    [BugFix] prevent infinite loop to return to wps from plugins
    
    if there is nothing to resume then it will return to the plugin endlessly
    hanging the device
    
    Change-Id: I7d6a0c7ec5a9e049cf62f88542bedaa1081556ac

diff --git a/apps/root_menu.c b/apps/root_menu.c
index 5a33146998..a546432d85 100644
--- a/apps/root_menu.c
+++ b/apps/root_menu.c
@@ -791,8 +791,8 @@ static int load_plugin_screen(char *key)
 
         if (ret == PLUGIN_USB_CONNECTED || ret == PLUGIN_ERROR)
             ret_val = GO_TO_ROOT;
-        else if (ret == PLUGIN_GOTO_WPS)
-            ret_val = GO_TO_WPS;
+        else if (ret == PLUGIN_GOTO_WPS) /* prevent infinite loop */
+            ret_val = old_global == GO_TO_WPS ? GO_TO_BROWSEPLUGINS : GO_TO_WPS;
         else if (ret == PLUGIN_GOTO_PLUGIN)
         {
             if(op_entry->lang_id == LANG_OPEN_PLUGIN)
-- 
rockbox-cvs mailing list
[email protected]
https://lists.haxx.se/mailman/listinfo/rockbox-cvs