%T#13978 Task opened by lenzone10: rbutil: keep the GUI responsive during voice and Talk file generation (Attachment added)
Rockbox via rockbox-sf <[email protected]>
| Newsgroups | gmane.comp.systems.archos.rockbox.sourceforge |
|---|---|
| Message-ID | <[email protected]> |
THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. A new Flyspray task has been opened. Details are below. User who did this - Alessio Lenzi (lenzone10) Attached to Project - Rockbox Summary - rbutil: keep the GUI responsive during voice and Talk file generation Task Type - Patches Category - Rockbox Utility (rbutil) Status - Unconfirmed Assigned To - Operating System - All players Severity - Media Priority - Molto Bassa Reported Version - Rbutil git Due in Version - Undecided Due Date - Undecided Details - Voice file and Talk clip generation currently run synchronously in the GUI thread. During long TTS operations this prevents the progress window from processing input and accessibility events. On Windows this makes the progress list unavailable to screen readers such as NVDA and can make Rockbox Utility appear to be hung. The attached patch moves VoiceFileCreator and TalkFileCreator to low-priority QThreads while keeping ProgressLoggerGui in the GUI thread. Progress and log signals are delivered through queued Qt connections. Cancellation remains available while a synchronous TTS request is running. The abort flags used across threads are atomic and the abort signal is sent through a direct connection. Worker objects and threads are deleted through the standard finished / deleteLater lifecycle. Talk generation now passes all selected folders to one worker and processes them sequentially, emitting the final done signal only once. This preserves multiple-folder selection without starting work in the GUI thread. No visual changes are made to either dialog. Tested with: - Windows, Qt 6.8.3 and licensed Vocalizer Expressive Luca through SAPI5. - Complete Italian voice file generation on an iRiver H300. - Voice generation cancellation followed by a successful restart in the same Rockbox Utility session. - Talk clip generation for single and multiple selected folders. - Talk generation cancellation during encoding followed by a successful restart in the same session (150 of 150 clips generated). - NVDA navigation of the progress list while voice and Talk generation were running. The generated voice file and Talk clips were also tested successfully on the players. Base revision: 85c1ff8667 One or more files have been attached. More information can be found at the following URL: https://www.rockbox.org/tracker/task/13978 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above. -- rockbox-sf mailing list [email protected] https://lists.haxx.se/mailman/listinfo/rockbox-sf