%T#13979 Task opened by lenzone10: rbutil: fix Talk file exclusion options and initial focus (Attachment added)

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY.

A new Flyspray task has been opened.  Details are below. 

User who did this - Alessio Lenzi (lenzone10) 

Attached to Project - Rockbox
Summary - rbutil: fix Talk file exclusion options and initial focus
Task Type - Patches
Category - Rockbox Utility (rbutil)
Status - Unconfirmed
Assigned To - 
Operating System - All players
Severity - Media
Priority - Molto Bassa
Reported Version - Rbutil git
Due in Version - Undecided
Due Date - Undecided
Details - The attached patch fixes three small issues found while testing Talk file
generation.

1. The "Ignore files" checkbox was saved in the settings but not consulted
   when starting generation. Patterns from the text field were therefore
   applied even when the checkbox was unchecked. The pattern list is now
   passed to TalkFileCreator only when the option is enabled.

2. Ignore patterns were converted to regular expressions by replacing only
   '*' and '?'. Other regular-expression characters were left unescaped and
   matches were not properly bounded. The patch uses Qt's
   wildcardToRegularExpression() conversion instead.

3. The Talk generation dialog initially focused "Strip Extensions" because of
   widget creation order. It now explicitly focuses the folder tree, matching
   the task flow and making keyboard and screen-reader use more predictable.

The handling of talkclips.ignore is also corrected so that files below a
marked directory are skipped recursively. Previously Rockbox Utility could
generate talkclips.ignore.talk and clips for files below .rockbox even though
.rockbox/talkclips.ignore was present.

Tested with:

- '*.voice' correctly excluded files when "Ignore files" was checked and had
  no effect when it was unchecked.
- The folder tree received initial focus and the existing Tab order remained
  usable with NVDA.
- With .rockbox/talkclips.ignore present, no clips were generated for files
  below .rockbox and no talkclips.ignore.talk was created. The folder's
  _dirname.talk remained available.
- Renaming the marker to talkclips.ignore.txt enabled normal generation again.
- A multiple-folder run skipped .rockbox contents while successfully creating
  clips in another selected folder.

Base revision: 85c1ff8667

This patch is independent of the worker-thread changes submitted as FS#13978.


One or more files have been attached.

More information can be found at the following URL:
https://www.rockbox.org/tracker/task/13979

You are receiving this message because you have requested it from the Flyspray bugtracking system.  If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.
-- 
rockbox-sf mailing list
[email protected]
https://lists.haxx.se/mailman/listinfo/rockbox-sf