Rsync deja vu with updated package

While continuing to install basic packages on my sacrficial virgin Sun
Netra, I began working on rsync.  The <check> method complained about two
failed tests.  This seemed vaguely familiar.

Back in February, when I first tried Arusha with try-ark, I wrote to
ark-users,
> The fun began when ark tried to test rsync.  Testing failed ...

Will Partain responded,
> Yes; you will find out that the <check> method (typically,
> it's the one in sidai/package/ALL.xml that gets run) is a
> pain, but it's not my fault :-) <check> typically just does
> 'make check', and package authors make horrible assumptions
> (an example is the Very GNU-ish assumptions you're bumping
> into) or the checks don't even work at all (sigh).

The horrible assumption was that rsync would be found on the execution path
during testing.  It wasn't.  (It would have been more horrible if an
installed, older rsync was found and the test was run with that version.)

Other tests that passed ran a specific rsync, defined as $RSYNC.

Will continues,
> ... the Right Thing is to then
> take diffs of the change you made and create a <patch>
> method for your rsync package.  (If you think it will apply
> to all rsync users in the world, then let's put the <patch>
> method in Sidai, rather than just for your team; but it's
> your choice...)

In the spirit of Will's guidance, here is a revised package for rsync--2.5.5
with patches to correct the failing tests. (Watch out for lines wrapped by
email systems.)  (I submitted the same patch, without the ark package, to
the rsync list.)

<package name="rsync--2.5.5" xml-version="1">
<status>revealed</status>
<prototypes>
  <prototype team="." name="GNU"/>
  <prototype team="." name="ALL"/>
</prototypes>
<!-- a copy deployment of rsync is desirable (small, important package)
 but problematic: it requires an RSYNC to work! -->

<!-- ..................................................... -->
<patch>
  <constraint><dependency type="essential" name="." on-method="src-linkfarm"
/></constraint>
  <param name="PATCH">@proxy-host:PATCH@</param>
<code once-per="site" redoable="no"><![CDATA[
cd $PKG_BUILD_DIR/src/testsuite
$PATCH chgrp.test <<\EOPATCH
*** testsuite/chgrp.test.orig	Tue Oct  8 11:16:33 2002
--- testsuite/chgrp.test	Tue Oct  8 11:16:48 2002
***************
*** 31,37 ****
  done
  sleep 2
  
! checkit "rsync -rtgvvv \"$fromdir/\" \"$todir/\"" "$fromdir" "$todir"
  
  exit 0
  # last [] may have failed but if we get here then we've won
--- 31,37 ----
  done
  sleep 2
  
! checkit "$RSYNC -rtgvvv \"$fromdir/\" \"$todir/\"" "$fromdir" "$todir"
  
  exit 0
  # last [] may have failed but if we get here then we've won
EOPATCH
$PATCH hardlinks.test <<\EOPATCH
*** testsuite/hardlinks.test.orig	Tue Oct  8 11:18:46 2002
--- testsuite/hardlinks.test	Tue Oct  8 11:19:00 2002
***************
*** 31,37 ****
  ln "$name2" "$name3" || fail "Can't create hardlink"
  cp "$name2" "$name4" || fail "Can't copy file"
  
! checkit "rsync -aHvv \"$fromdir/\" \"$todir/\"" "$fromdir" "$todir"
  
  exit 0
  # last [] may have failed but if we get here then we've won
--- 31,37 ----
  ln "$name2" "$name3" || fail "Can't create hardlink"
  cp "$name2" "$name4" || fail "Can't copy file"
  
! checkit "$RSYNC -aHvv \"$fromdir/\" \"$todir/\"" "$fromdir" "$todir"
  
  exit 0
  # last [] may have failed but if we get here then we've won
EOPATCH
]]></code></patch>
</package>

--

Joel Shprentz
National Imagery and Mapping Agency
Mailstop N-17
Washington Navy Yard, Building 213
1200 First Street, SE
Washington, DC 20303-0001

202-685-3534




-------------------------------------------------------
This sf.net email is sponsored by:ThinkGeek
Welcome to geek heaven.
http://thinkgeek.com/sf