Re: [PATCH] tests: fix py-compile-basedir.sh: add missing test call
Mike Frysinger <[email protected]>
| Newsgroups | gmane.comp.sysutils.automake.patches |
|---|---|
| Message-ID | <Yed3wMY0ai2GNISy@vapier> |
On 18 Jan 2022 11:29, Jim Meyering wrote: > On Tue, Jan 18, 2022 at 10:29 AM Mike Frysinger wrote: > > On 18 Jan 2022 09:48, Jim Meyering wrote: > ... > > > But IMHO that's too much duplication/syntax. > > > How about this instead? > > > > > > case $(echo "$files" | wc -l) in 4|6) ;; *) false;; esac > > > > looks reasonable for POSIX shell. not a fan of the one-line, but that style > > seems to be SOP for test code, so i won't whine too loudly :p. > > > > i assume you'll take care of writing the actual patch at this point since it > > was your idea ? :) > > Sure. How about this? lgtm, thanks -mike
signature.asc
(application/pgp-signature, 833 B)
-----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEuQK1JxMl+JKsJRrUQWM7n+g39YEFAmHnd78ACgkQQWM7n+g3 9YGTew/9FrEkG0YbBRX6+Z6LhH9+XpXyurx9sgYCpYF6irl2em3r1AR8DvnZNWXq t8jtuMhzkjjmuTr3jP5OiV6TFf5CVgvGFF4+MmQ2yLnfgisDurkJovNNMaR9kXfE /2n51k6/9fVsHiKsx/6DdCVkcHZ2OQ0FYQnIbLWEUMaqe7Zbzg2fVqbgppdvGTor LEf5QLhOnQpZ+DOLcjvsveOZE4R3f4A4eF8wJ2x6YY8IzRPF5Mu8HTtrY9H796lJ TuzfytliVaFTBihJseLa15FWOHCIvKnONagZ9CR7gSj8Xu+pTm9Xky790kP+AmYU vZ8VIurlQ/MPPOCsxr/pGC/kD+dy4pLlOCQDm9FjeZ50pKZYcY29YGG28VCbIg7g BtJVLbPCexFdREuu5sT05hVALcRiEnsNsqRVHjmDvFrCKlaRsDyhOVy6YPwgaPw4 K5Am5hD6aQTO4dyLlViSXXgU44TDRLF+PeoaGMqtgVTjloTzMq9B2HV08v2AdiO3 zXLt1fbHYRJZ5mmBGCMhbDhZy9vgrTbZZZsknpG9gbcEwFU3jy2xuiyE2wUkbBu9 I895EvWeqmX8nJboJdbbKpLd7a9mTmGRGpeKFnZdcj572ZBvseJC6PhxO94tJsLN gn7GbuzOfMgBe7Ey1lD8rQGyHbuhW/I93WPIM8OWYNUlh2NKPPg= =oJcv -----END PGP SIGNATURE-----