Re: PATCH: silence Shellcheck warning

On 18 Jan 2022 21:25, Ben Elliston wrote:
> On Tue, Jan 18, 2022 at 04:18:52AM -0500, Mike Frysinger wrote:
> > that said, automake targets lower than POSIX, so i agree that we
> > should leave it be for automake specifically.  feel like posting a
> > patch to suppress this particular check in lib/missing instead ?
> 
> If it's welcome, sure. Some people are opposed to littering pragmas
> through source files to disable linters that they think do more harm
> than good.

tl;dr: using shellcheck directives in automate shell scripts sgtm.

shell does not lend itself to being written correctly.  shellcheck has
proven its worth to me multiple times over, especially because i can stop
having to point out the same mistakes to people over & over that it easily
finds.  we've integrated into CrOS & internally at Google and people love
it.  at least, people still (rightly) hate shell, but not much to be done
about that other than use a better language :P.
-mike

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEuQK1JxMl+JKsJRrUQWM7n+g39YEFAmHnfFsACgkQQWM7n+g3
9YFcaw//aEAlVTEd0Hg7JqbdR8GUh2ld1ZMqMyLTMZlWJAOKnHpcGhP0BIohgKQG
yWquL/pHR6zhTpIByAlAfg7Lu7zfYKQ9/3cT0RMu6KTBcwPFvoEQER7f5qt93tbR
Zmw6ARu9JF6q0PmPIXQ8o8KGLqQtZSwNqRNbtr29IvN3YLWSigyzPLTRvmRrMcwu
jou5Cd8zrYQHlfN6wdVJI6NAFK6N9n0nvi6hRgw+rk0EoEAS/JVs9/+s7VMiSTp1
fk2BnEfK76c0rg4XkreNMX6JZb4Ws5NUk3okcLiCv+8qSLx9pJUGWWGk4msSYqNN
LG9N3+jNpAs18OWS8pZke8/E9qjoSgHlhqYhTW03vERCSi7xdMkQtMQBe/XQFIm+
K1SP41Ymt8NtBBX57EknXWRPi7+RS2qF4z9l6fLGuopgOqrRUkXaOX/W/GEp7ON5
vDkdlpcmbk4RI0cYgICnPIS/vlxld19TyHw1fhPaeWZ2rxiZS9xhy410fBkp78j4
xi07ekXTtWREza/CaF/vGNQopj3QRhHGg6ELNaFV1JJ9YM9xxrkfaau2SofJagJo
wL205SOpiCs1JCdMyxIpIMEhXQtOQN1bBlu127lRU6HX29tlzXKnNIr4+kY7nE+3
GE6icERa4fwdHi6iy5glVD6+bRqDqh4EbSdTeFVqiPHToK+72XQ=
=5IqX
-----END PGP SIGNATURE-----