Re: [PATCH] PATH: use double quote

Eric Blake <[email protected]> Mon, 22 Sep 2014 21:32:44 -0600

Newsgroups	gmane.comp.sysutils.automake.patches
Organization	Red Hat, Inc.
Message-ID	<[email protected]>

On 09/22/2014 08:06 PM, KO Myung-Hun wrote:

> 
>> Why are you changing this? I see no difference in the resulting
>> shell syntax, except that backslashes in $(abs_builddir) are now
>> handled differently.  You need a lot more justification for WHY
>> this patch is necessary.
> 
> 
> On OS/2, PATH_SEPARATOR is ';'. If is is not quoted, ';' works as a
> mark of end of sentence. And how about this for $(abs_builddir) ? At
> least, it works here.
> 
>  -  { PATH='$(abs_builddir)/t/wrap'$(PATH_SEPARATOR)$$PATH && export
> PATH; }
>  +  { PATH='$(abs_builddir)/t/wrap'"$(PATH_SEPARATOR)$$PATH" && export
> PATH; }

Ah, that's the sentence you were missing from your proposed change.
Note that $$PATH doesn't need to be quoted, but the makefile expansion
of $(PATH_SEPARATOR) does; but it would also be sufficient to use:

{ PATH='$(abs_builddir)/t/wrap$(PATH_SEPARATOR)'$$PATH && export PATH; }

if we're trying to go for the shortest line.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc (application/pgp-signature, 539 B)