Re: [PATCH] PATH: use double quote

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1



Eric Blake wrote:
> On 09/22/2014 08:06 PM, KO Myung-Hun wrote:
> 
>> 
>>> Why are you changing this? I see no difference in the
>>> resulting shell syntax, except that backslashes in
>>> $(abs_builddir) are now handled differently.  You need a lot
>>> more justification for WHY this patch is necessary.
>> 
>> 
>> On OS/2, PATH_SEPARATOR is ';'. If is is not quoted, ';' works as
>> a mark of end of sentence. And how about this for $(abs_builddir)
>> ? At least, it works here.
>> 
>> -  { PATH='$(abs_builddir)/t/wrap'$(PATH_SEPARATOR)$$PATH &&
>> export PATH; } +  {
>> PATH='$(abs_builddir)/t/wrap'"$(PATH_SEPARATOR)$$PATH" && export 
>> PATH; }
> 
> Ah, that's the sentence you were missing from your proposed
> change. Note that $$PATH doesn't need to be quoted, but the
> makefile expansion of $(PATH_SEPARATOR) does; but it would also be
> sufficient to use:
> 
> { PATH='$(abs_builddir)/t/wrap$(PATH_SEPARATOR)'$$PATH && export
> PATH; }
> 
> if we're trying to go for the shortest line.
> 

Ok. I confirmed that this worked well here, too.

Thanks.

Should I re-send a patch ?

- -- 
KO Myung-Hun

Using Mozilla SeaMonkey 2.7.2
Under OS/2 Warp 4 for Korean with FixPak #15
In VirtualBox v4.1.32 on Intel Core i7-3615QM 2.30GHz with 8GB RAM

Korean OS/2 User Community : http://www.ecomstation.co.kr

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.7 (OS/2)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iD8DBQFUIPEuE9YstvghgroRAvwuAKCn7b8Cip1JQk7oo/W1E85i/wVOOwCgoS4D
OIpQydAgt+UMiRmsPj6Cmp0=
=wxlT
-----END PGP SIGNATURE-----