Re: build on systems without sbrk

Martin Simmons <[email protected]> Tue, 12 Dec 2023 17:03:47 GMT
Newsgroups gmane.comp.sysutils.backup.bacula.devel
Message-ID <[email protected]>
>>>>> On Sat, 9 Dec 2023 11:30:21 -0500, Dan Langille said:
> 
> Some time ago, the FreeBSD ports of bacula9, bacula11, and bacula13 were all marked as broken on aarch64 and riscv64 because of missing sbrk
> 
> Will the upcoming Bacula 15 release have the same issue?

Yes, I think so.


>                                                          If so, let's fix it in the code, so we don't have to patch it down stream? I'm sure it affects more than FreeBSD.

There is no standard way to get the memory usage, so it has to be OS specific.

> references:
> 
> * https://www.freshports.org/sysutils/bacula9-client/ - 01 Jan 2021 23:51:49
> 
> Now we a code review which should allow the build to succeed on hosts without sbrk.  I hope this can help our code.
> 
> https://reviews.freebsd.org/D42979

The patch in the review looks good to me for FreeBSD as long as "report no
heap usage" is OK.

__Martin