Re: diff compression

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 29/07/2015 21:24, gulikoza wrote:
> Hi,

Hi,

> 
>> Just a status to let you know.
>> 
>> I have started implementing an adhoc interface to librsync into
>> libdar
> 2.5.x however I face what seems to be a bug in librsync which I
> have no time to troubleshoot nor fix.
> 
> Whoa...thanks for the update :)
> 
>> more details at 
>> https://sourceforge.net/p/librsync/mailman/message/34205320/
>> 
> 
> I have checked your program and the message on SF. I have done a
> quick review of the code (I apologize if I'm stating something
> obvious...let me know :-)) The test program crashes because
> tag_table is NULL:

Thanks for you investigations. A different point of view is *always*
valuable :-) I will review your remarks on Friday and let you know.

> 
> (gdb) print sig->tag_table $3 = (int *) 0x0
> 
> Tag_table is initialized in rs_build_hash_table()... Now, rdiff
> program calls rs_build_hash_table(sumset) explicitly and then uses
> rs_delta_file() which in turn calls rs_delta_begin(). Your
> 'my_rdiff' only calls rs_delta_begin()...
> 
> Adding rs_build_hash_table(sumset); before rs_delta_begin() no
> longer crashes the program and I don't see rs_build_hash_table()
> being called anywhere from librsync, so I guess the table has to be
> built explicitly...
> 
>> except that point, the base relation between librsync and libdar
>> is done.
> Remains a lot of work to do for within libdar.
>> 
>> Due to the lack of time and already 6 month since the expected
>> release of
> 2.5.0 I must postpone this feature to 2.6.x this feature.
>> However I will start by its implementation, so maybe a new branch
>> could be
> done sooner than the average 3 years between major releases of
> libdar.
>> 
>> 
>> Thanks for your comprehension,
> 
> Thank you for the update and keep us informed :-)
> 
> Regards, gulikoza

Cheers,
Denis.

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQIVAwUBVblEZAgxsL0D2LGCAQIRohAAvIEfq23s57mtWHTryEt8ylIeoxDKX8Dz
9D+rpOWtU3aUoyozwCtQCT5G5/Dr4e+k1duuICn9nI7oYWxVXTPXBeBmV5w7zbXW
f7TmX+V6vv9G+kY3omcPxtp/OO/gH8llDlQuCgqHDiUztlj81iT5o8ZL0Sj+e0dL
fxuE3HEpOs6Qe7FZpRynDrECo4MPjf93v+FSsGRtkMTaaKTzlbB4aX/0RZwP33YU
6nes3C84vQaiHUYxsXIvSe6nN31ZEO54UDVhZzlbg23pL0xAXFgQgdtlr4DH8mVZ
RfTdYRuCPqhhUbKtYRbYn2kv3fO5ChK2lKT+a8HzHwPbvvucZboAQfTpbYqwi8Lh
q7O/1T2VKwTeeVNmlpI/o3IpOnDIo16PtxUBSf9/eWjBmhgcKffOxtj811Wfj7bP
K/3f1YnhKAO1Csg+JUfvccr2lL2ujmucVkPYNbds9ury8xZzdiTpw38ysu9i1hrR
kUDhD3W/vMB9TFtWYE48mTFKsQKJ53jb6aK9KCFZCQtoWdVvSkOXJRmWBNYJNjlc
gsVeqTgWi/hU27J8l78EJnBVJf3bzq/jRNy6fMpmjJlberguiD8cmC+iWd7F7RB/
hvO+ap0iTs2LIEllmJalcwAmoyVF5v3QQPjrFAQldQme0i9BN6seb0O/Yx4wCyUh
edPcw7BBFyg=
=i3EZ
-----END PGP SIGNATURE-----

------------------------------------------------------------------------------