Re: diff compression

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hello Gulikoza,

[...]

> 
>> I have checked your program and the message on SF. I have done a
>> quick review of the code (I apologize if I'm stating something
>> obvious...let me know :-)) The test program crashes because
>> tag_table is NULL:
> 
> Thanks for you investigations. A different point of view is *always*
> valuable :-) I will review your remarks on Friday and let you know.
> 
> 
>> (gdb) print sig->tag_table $3 = (int *) 0x0
> 
>> Tag_table is initialized in rs_build_hash_table()... Now, rdiff
>> program calls rs_build_hash_table(sumset) explicitly and then uses
>> rs_delta_file() which in turn calls rs_delta_begin(). Your
>> 'my_rdiff' only calls rs_delta_begin()...
> 
>> Adding rs_build_hash_table(sumset); before rs_delta_begin() no
>> longer crashes the program and I don't see rs_build_hash_table()
>> being called anywhere from librsync, so I guess the table has to be
>> built explicitly...


I only could find time for that today... so, you were 100% right!
rs_build_hash_table() was missing before rs_delta_begin()... plus a bug
in my delta routine that did not extracted all the produced data, fixed
the problem.

So, yes, a different point of view was really valuable!
And yes, documentation of software is not vain (librsync is really
poorly documented).

Anyway thank you for your help, delta diff feature inside libdar is back
on track, now! :)

Cheers,
Denis.


-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQIVAwUBVciNwggxsL0D2LGCAQLrLA//cKwcn1CEnM1oTHhgU/rkCKBeum0D88rI
dVVBSJbbdRxzv0Eqh3B3ox3xafUbkE3wBXV24hKuqK3Wty2lL6+aKL5YHCEu0ddF
WhoRzrQdqIcm3fs4M7VKscLEk1C5xxVlsjfB2GQlFcODQFLBVk/a3Jb61EzrsTow
CgKV6zjuh3cn2WyYqQCt5rBjc66W5CrxT49KtAWLN02tzhr+PK9DJAkgcNKlyemV
bfjDMgUb70SDdrn0XrRZLMhDe25U+Y0+r65VnsREs52OZHQPf21NIKptf7hUR5rs
uGWz08KlFRmr9krug2AxN2oA3PGX1jvKu6babvrnGfFOhPfxWNwDgW6lXvX1tucr
snJ2tdIUvJV/TdGthufcYBAaRVCECL7MnsbB6dV8h+CVnvZ4xulrw1CVEwEf/SW4
F/O4fjf8SeQ/+FK9MtyyNdGrV38tB2drFGV7vIVR0fXZOjhZeUAxiH+NuARhmw8r
BjybnjWBGAL3AtNhN4VJWn7DsZs7qmJO6me+z75Q6ImbczF6yFCy0rs113TTQzez
7lmK8ifM2U5lS6FZt5bL3ixNwBGTlYIF0KLGudzCKGLnXKgBXAOmx9IPRPAJh4Qo
yqWt/JWuBv39Udl/m5crEDqSRfwKnF/se3SF5S3YTQ3ebKYdrMWOOjaNsd7loG/8
a91qu1QA2Vc=
=8Njs
-----END PGP SIGNATURE-----

------------------------------------------------------------------------------