Problem with 1.6.29 bugfix release and /etc/hdup/hdup.conf

Hello Miek,

I have been using your great program for perfoming backups for some
time. Recently, it has been added to the portage three of the Gentoo
Linux distribution (I had helped a bit in that process).
However, there is a problem with config file location in the latest
bugfix release, which is described in the ChangLog as:

"bugfix: location of hdup.conf in hdup.h.in now has @prefix@ as prefix
 (Thanks to Uli Bubenheimer for reporting). Also make hdup.1 reflect the
 correct location"

This change causes that when one choose the default prefix to
/usr for example (as it is defined in Gentoo's hdup-1.6.29.ebuild) the
location of hdup.conf is somehow strange: /usr/etc/hdup/hdup.conf,
instead of assumed /etc/hdup/hdup.conf.
The Gentoo's hdup-1.6.29.ebuild uses such a form of invoking 'make
install' command:

"make prefix=3D${D}/usr mandir=3D${D}/usr/share/man sysconfdir=3D${D}/etc=
 \
                install || die"

where, ${D} is a temporary directory, which is finally changed into
root directory "/". But the 'sysconfdir' can not be used in that way,
since there is a hard statement in your src/hdup.h.in source file.

To solve this problem I suggest using the sysconfdir parameter in your
configure script, which could be set to ${prefix}/etc as default. But it
requires some changes in src/hdup.h.in (here is the patch):

--- src/hdup.h.in.orig  2004-04-27 19:31:05.779891904 +0200
+++ src/hdup.h.in       2004-04-27 19:31:36.414234776 +0200
@@ -23,7 +23,7 @@
 #define LZOP_PROG      "@lzop@"                                        =20
         =20
 #define SPLIT_PROG      "@split@"                                      =20
         =20
 #define UNSPLIT_PROG    "@cat@"                                        =20
         =20
-#define ETCFILE         "@prefix@/etc/hdup/hdup.conf"
+#define ETCFILE         "@sysconfdir@/hdup/hdup.conf"
 #define REMOTE_HDUP     "/usr/local/bin/hdup"                          =20
         =20
 #define REMOTE_HDUP_OPT ""      /* default is empty */                 =20
         =20
 #define FILELIST        "/filelist"                                    =20
         =20

and also in the configure script, which I haven't changes, because it is
generated by autoconf. So I left this correction as your homework.

I hope you correct this inconvenience in the forseeable future ;)

Best wishes and keep coding,

ediap


--=20
-=3D#=3D-  Adam Piatyszek - "ediap"    -=3D#=3D-  Liunx ID: #204648      =
 -=3D#=3D-
-=3D#=3D-  ediap (at) et.put.poznan.pl -=3D#=3D-  JID: [email protected]=
 -=3D#=3D-
-=3D#=3D-  http://www.ediap.prv.pl     -=3D#=3D-  Gadu-Gadu: 1157376     =
 -=3D#=3D-

----------------------------------------------------
U nas oferty wyjazd=F3w i wycieczek z Gwarancj=B1 Najni=BFszej Ceny!
Masz pewno=B6=E6, =BFe kupujesz najtaniej!
http://klik.wp.pl/?adr=3Dhttp%3A%2F%2Fturystyka.wp.pl%2Fwycieczki.html%3F=
dzial%3Dslm&sid=3D168