Re: [PATCH] hd44780-charmap.h imon.c Russian charmaps

On 29.03.2011 22:09, Markus Dolze wrote:
> On 29.03.2011 21:01, Yura Scheglyuk wrote:
>>         Hi!
>>
>> I made the new version of two additional Russian charmaps - CP-1251
>> (Windows-1251) and ISO 8859-5 according principle of previous patch of
>> koi8-r charmap. I removed pseudo-graphics symbols because it's rarely
>> used and remapping symbols like HEART and so on.
>>
>> Markus, could you please commit this patch? If you'll approve this
>> patch all Russian users will say you "SPASIBO!".
>>
>> There are a lot of lcdproc clients like XBMC, VDRs etc. For example,
>> CP1251 used in XBMC and XBMC does not contains KOI8-R translation;
>> ISO-8859-5 used in XBMC and some VDR packages - russian EPG comes from
>> satellites in ISO-8859-5 charset. Now users have to patch ALL software
>> projecs to map international charmaps to VFD charmaps. Therefore I
>> think that adding mapping of input characters in ONE lcdproc project
>> is the best way to get international (not only russian but Cyrillic at
>> all - Ukrainian, Belorussian, Bulgarian, etc.) users support. In this
>> case lcdproc will have complete Russian solution "out of the box" and
>> this can lead to wide growing of UNIX popularization among users.
> Hi,
>
> originally I was not a friend of adding these additional mappings as
> they will encourage more users to implement mappings from other
> languages and I think LCDproc should not need to cope with different
> input character sets on its own.
>
> Instead one solution would be to map Anything->Unicode->HD44780, e.g.
> using libiconv. Unfortunately nothing like Unicode->HD44780 exists to my
> knowledge so we will end up using our own mapping tables again and using
> wide characters in the server core will require extensive rework of it
> and I don't even think of doing this.
>
> Therefore, if you agree on having those tables as a compile time option
> (e.g. ./configure --with-extra-encodings) I am happy to commit them.
>
> Regards,
> Markus
>

Hi,

committed.

As suggested above you need to regenerate the configure script and
configure LCDproc with '--enable-extra-charmaps' (which I think is more
appropriate as '-encodings'). Drivers and documentation has been
modified accordingly.

Regards,
Markus