Re: [PATCH] adding support for AAEON FWS-7600 LCM

On 24.03.2011 13:37, Malte Pöggel wrote:
> Hi Markus,
>
> Am 23.03.2011 20:06, schrieb Markus Dolze:
>>    1. Please refrain from using the semaphore stuff. It is ancient code
>>       used to mediate access between LCDproc and  programs called
>>       'lcdtime' (and I think 'meter').
> I did not know what the semaphore stuff was good for, so i left it in.
>
> I've now removed it and attatched the corrected patch and the schematics
> for the "aaeon" lcd and keypad wiring.
>
>
>>    2. I am a little reluctant adding drivers for ready-built cases
>>       (especially if appliances are used for something else than
>>       originally intended). [...]
> I developed this driver at work, we are using the appliances for a
> firewall system.
> The display was not used till now, but a uninitialized LCD seems to be
> very confusing to our customers and so i wrote the patch ;-)
>
>
> Malte
>

Hi,

Several questions:

1. Did the keypad work correctly? In aaeon_init there is the call

p->stuckinputs = lcdtime_HD44780_readkeypad(p, 0);

Calling lcdtime_HD44780_readkeypad() may work but it is intended
behaviour? p->stuckinputs is not used elsewhere in the aaeon driver, too.

2. Is the circuit you supplied as aaeon-keys.txt already hooked up?

3. Does this device has some output at all (LEDs, etc)? If not, the
aaeon_output function is superfluous.

There has been a typo in the Makefile.am for the header file (fixed that
already).

Regards,
Markus