Re: Fix build on OpenBSD
Markus Dolze <[email protected]> Wed, 16 Nov 2011 20:32:40 +0100
| Newsgroups | gmane.comp.sysutils.lcdproc |
|---|---|
| Message-ID | <[email protected]> |
On 16.11.2011 16:15, Edd Barrett wrote: > Hi, > > Tihs fixes the build on OpenBSD, hopefully it is correct: > ... > Thanks Hi, you are one of the very few users running LCDproc on OpenBSD and likely the first running it on 5.0 (which has just been released). Last time I did was OpenBSD 4.3... Please send in patches as attachments, not inline. Thank you. Regarding the patch: 1. Using <machine/apmvar.h> seems to be the preferred way. In old OpenBSD 'machine' is just a symlink to 'i386' and all man pages instruct to use machine/apmvar.h. Will commit this. 2. kvm_getprocs() with 5 parameters seems to be new on OpenBSD 5. Thus the patch will likely break any older version. There must be a check on either OpenBSD version or on the parameter set kvm_getprocs() accepts (likely in configure script). I'm currently not deep enough into OpenBSD to do this. Somebody else? Regards, Markus