Re: Patch adds support for the Adafruit PiPlate
Jonathan Brogdon <[email protected]> Mon, 8 Apr 2013 14:59:45 -0500
| Newsgroups | gmane.comp.sysutils.lcdproc |
|---|---|
| Message-ID | <CANAYU8ZgxU-++MjAnPg1d-bCLVOqGr2CWWFknEHodSRQTKF2sw@mail.gmail.com> |
--===============7643348188667407930== Content-Type: multipart/alternative; boundary=f46d042ef753dd5f6e04d9dee05a --f46d042ef753dd5f6e04d9dee05a Content-Type: text/plain; charset=ISO-8859-1 Thanks, Markus. I only had time this weekend to check the LCD output, and everything was fine. I'll check the keys in next day or so. Jon On Sun, Apr 7, 2013 at 7:05 AM, Markus Dolze <[email protected]> wrote: > Hi, > > committed (with documentation). Thank you. > > You should test the driver, as I have made some changes to it: > - Rename the whole thing to piplate (instead of i2c-piplate; however, > the internal function names have not been changed). > - Optimize senddate() / backlight() to reduce I2C traffic. > - Consolidate write_4_nibble() into senddata(). > - Change the default I2C device for Pi Rev 2. > - Add FreeBSD support (not that anyone is running this on a Pi, but to > allow me to compile the driver on my development machine). > > Regards, > Markus > > > On 25.03.2013 20:58, Jonathan Brogdon wrote: > > OK. Thanks, Markus. Let me know if there is anything else I can > provide. > > > > Jon > > > > On Mon, Mar 25, 2013 at 1:26 PM, Markus Dolze <[email protected] > > <mailto:[email protected]>> wrote: > > > > Hi Jon, > > > > thank you for your submission. You don't need to resubmit patches > > (unless it doesn't show up in the mailing list archive). They are > > reviewed if I have some spare time. > > > > Regards, > > Markus > > > > On 25.03.2013 14 <tel:25.03.2013%2014>:18, Jonathan Brogdon wrote: > > > Never saw a response on the corrected patch for the Adafruit > PiPlate. > > > Resubmitting. > > > > > > Jon > > > > > > ---------- Forwarded message ---------- > > > From: *Jonathan Brogdon* <[email protected] > > <mailto:[email protected]> > > > <mailto:[email protected] <mailto:[email protected]>>> > > > Date: Mon, Feb 18, 2013 at 9:34 AM > > > Subject: [Lcdproc] Patch adds support for the Adafruit PiPlate > > > To: [email protected] > > <mailto:[email protected]> > > <mailto:[email protected] > > <mailto:[email protected]>> > > > > > > > > > You are correct regarding the blue backlight pin. I've fixed the > > > code, and attached a new patch. > > > > > > Jon > > > > > > > > > On Tue, Feb 12, 2013 at 1:29 AM, Markus Dolze > > <[email protected] <mailto:[email protected]> > > > <mailto:[email protected] <mailto:[email protected]>>> > wrote: > > > > > > On 11.02.2013 22:32, Jonathan Brogdon wrote: > > > > Never saw this on the mailing list, or a response. > Re-sending. > > > > > > > > Jon > > > > > > > > ---------- Forwarded message ---------- > > > > From: *Jonathan Brogdon* <[email protected] > > <mailto:[email protected]> > > > <mailto:[email protected] <mailto:[email protected]>> > > > > <mailto:[email protected] <mailto:[email protected]> > > <mailto:[email protected] <mailto:[email protected]>>>> > > > > Date: Sat, Feb 9, 2013 at 1:26 AM > > > > Subject: [PATCH] Add support for the Adafruit PiPlate > > > > To: [email protected] > > <mailto:[email protected]> > > > <mailto:[email protected] > > <mailto:[email protected]>> > > > <mailto:[email protected] > > <mailto:[email protected]> > > > <mailto:[email protected] > > <mailto:[email protected]>>> > > > > > > > > > > > > For your consideration, I have attached a v0.5.6 patch which > > adds a > > > > driver for the Adafruit PiPlate > > (http://adafruit.com/products/1109). > > > > The PiPlate includes a HD44780 LCD and 5 button keys which > is > > > > accessed via a MCP23017 I2C IO expander. > > > > > > > > The driver was adapted from the HD44780-i2c driver, which > > uses the > > > > PCF8574 I2C IO expander. > > > > > > > > Jon Brogdon > > > > > > > > > > Hi, > > > > > > please read [1]. Thank you. > > > > > > [1] > > http://lcdproc.sourceforge.net/docs/current-dev.html#code-style > > > > > > According to the schematic from [1], the pin for blue > > backlight is on > > > GPB0, not on GPA8 (which does not exist anyway). > > > > > > Is the schematic wrong or did I miss something? > > > > > > [2] > > > > > > http://learn.adafruit.com/system/assets/assets/000/003/861/original/pilcdplate.png?1360171818 > > > > > > Regards, > > > Markus > > > > > > _______________________________________________ > > > LCDproc mailing list > > > [email protected] > > <mailto:[email protected]> > > <mailto:[email protected] > > <mailto:[email protected]>> > > > http://lists.omnipotent.net/mailman/listinfo/lcdproc > > > > > > > > > > > > > > > > > > > > > _______________________________________________ > > > LCDproc mailing list > > > [email protected] <mailto:[email protected]> > > > http://lists.omnipotent.net/mailman/listinfo/lcdproc > > > > _______________________________________________ > > LCDproc mailing list > > [email protected] <mailto:[email protected]> > > http://lists.omnipotent.net/mailman/listinfo/lcdproc > > > > > --f46d042ef753dd5f6e04d9dee05a Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable <div dir=3D"ltr">Thanks, Markus. =A0I only had time this weekend to check t= he LCD output, and everything was fine. =A0I'll check the keys in next = day or so.<div><br></div><div style>Jon</div></div><div class=3D"gmail_extr= a"><br> <br><div class=3D"gmail_quote">On Sun, Apr 7, 2013 at 7:05 AM, Markus Dolze= <span dir=3D"ltr"><<a href=3D"mailto:[email protected]" target=3D"_= blank">[email protected]</a>></span> wrote:<br><blockquote class=3D"= gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-= left:1ex"> Hi,<br> <br> committed (with documentation). Thank you.<br> <br> You should test the driver, as I have made some changes to it:<br> - Rename the whole thing to piplate (instead of i2c-piplate; however,<br> the internal function names have not been changed).<br> - Optimize senddate() / backlight() to reduce I2C traffic.<br> - Consolidate write_4_nibble() into senddata().<br> - Change the default I2C device for Pi Rev 2.<br> - Add FreeBSD support (not that anyone is running this on a Pi, but to<br> allow me to compile the driver on my development machine).<br> <br> Regards,<br> Markus<br> <div class=3D"im"><br> <br> On <a href=3D"tel:25.03.2013%2020" value=3D"+12503201320">25.03.2013 20</a>= :58, Jonathan Brogdon wrote:<br> > OK. =A0Thanks, Markus. =A0Let me know if there is anything else I can = provide.<br> ><br> > Jon<br> ><br> > On Mon, Mar 25, 2013 at 1:26 PM, Markus Dolze <<a href=3D"mailto:bs= [email protected]">[email protected]</a><br> </div><div class=3D"im">> <mailto:<a href=3D"mailto:bsdfan@nurfuerspa= m.de">[email protected]</a>>> wrote:<br> ><br> > =A0 =A0 Hi Jon,<br> ><br> > =A0 =A0 thank you for your submission. You don't need to resubmit = patches<br> > =A0 =A0 (unless it doesn't show up in the mailing list archive). T= hey are<br> > =A0 =A0 reviewed if I have some spare time.<br> ><br> > =A0 =A0 Regards,<br> > =A0 =A0 Markus<br> ><br> </div><div class=3D"im">> =A0 =A0 On <a href=3D"tel:25.03.2013%2014" val= ue=3D"+12503201314">25.03.2013 14</a> <tel:25.03.2013%2014>:18, Jonat= han Brogdon wrote:<br> > =A0 =A0 > Never saw a response on the corrected patch for the Adafr= uit PiPlate.<br> > =A0 =A0 > =A0Resubmitting.<br> > =A0 =A0 ><br> > =A0 =A0 > Jon<br> > =A0 =A0 ><br> > =A0 =A0 > ---------- Forwarded message ----------<br> > =A0 =A0 > From: *Jonathan Brogdon* <<a href=3D"mailto:jlbrogdon@= gmail.com">[email protected]</a><br> > =A0 =A0 <mailto:<a href=3D"mailto:[email protected]">jlbrogdon@gm= ail.com</a>><br> </div><div class=3D"im">> =A0 =A0 > <mailto:<a href=3D"mailto:jlbr= [email protected]">[email protected]</a> <mailto:<a href=3D"mailto:jlbro= [email protected]">[email protected]</a>>>><br> > =A0 =A0 > Date: Mon, Feb 18, 2013 at 9:34 AM<br> > =A0 =A0 > Subject: [Lcdproc] Patch adds support for the Adafruit Pi= Plate<br> > =A0 =A0 > To: <a href=3D"mailto:[email protected]">lcdpr= [email protected]</a><br> > =A0 =A0 <mailto:<a href=3D"mailto:[email protected]">lcd= [email protected]</a>><br> </div><div class=3D"im">> =A0 =A0 <mailto:<a href=3D"mailto:lcdproc@l= ists.omnipotent.net">[email protected]</a><br> > =A0 =A0 <mailto:<a href=3D"mailto:[email protected]">lcd= [email protected]</a>>><br> > =A0 =A0 ><br> > =A0 =A0 ><br> > =A0 =A0 > You are correct regarding the blue backlight pin. =A0I= 9;ve fixed the<br> > =A0 =A0 > code, and attached a new patch.<br> > =A0 =A0 ><br> > =A0 =A0 > Jon<br> > =A0 =A0 ><br> > =A0 =A0 ><br> > =A0 =A0 > On Tue, Feb 12, 2013 at 1:29 AM, Markus Dolze<br> > =A0 =A0 <<a href=3D"mailto:[email protected]">bsdfan@nurfuerspa= m.de</a> <mailto:<a href=3D"mailto:[email protected]">bsdfan@nurfuer= spam.de</a>><br> </div><div><div class=3D"h5">> =A0 =A0 > <mailto:<a href=3D"mailto= :[email protected]">[email protected]</a> <mailto:<a href=3D"mai= lto:[email protected]">[email protected]</a>>>> wrote:<br> > =A0 =A0 ><br> > =A0 =A0 > =A0 =A0 On 11.02.2013 22:32, Jonathan Brogdon wrote:<br> > =A0 =A0 > =A0 =A0 > Never saw this on the mailing list, or a res= ponse. =A0Re-sending.<br> > =A0 =A0 > =A0 =A0 ><br> > =A0 =A0 > =A0 =A0 > Jon<br> > =A0 =A0 > =A0 =A0 ><br> > =A0 =A0 > =A0 =A0 > ---------- Forwarded message ----------<br> > =A0 =A0 > =A0 =A0 > From: *Jonathan Brogdon* <<a href=3D"mail= to:[email protected]">[email protected]</a><br> > =A0 =A0 <mailto:<a href=3D"mailto:[email protected]">jlbrogdon@gm= ail.com</a>><br> > =A0 =A0 > =A0 =A0 <mailto:<a href=3D"mailto:[email protected]"= >[email protected]</a> <mailto:<a href=3D"mailto:[email protected]">= [email protected]</a>>><br> > =A0 =A0 > =A0 =A0 > <mailto:<a href=3D"mailto:jlbrogdon@gmail= .com">[email protected]</a> <mailto:<a href=3D"mailto:jlbrogdon@gmail.= com">[email protected]</a>><br> > =A0 =A0 <mailto:<a href=3D"mailto:[email protected]">jlbrogdon@gm= ail.com</a> <mailto:<a href=3D"mailto:[email protected]">jlbrogdon@gma= il.com</a>>>>><br> > =A0 =A0 > =A0 =A0 > Date: Sat, Feb 9, 2013 at 1:26 AM<br> > =A0 =A0 > =A0 =A0 > Subject: [PATCH] Add support for the Adafrui= t PiPlate<br> > =A0 =A0 > =A0 =A0 > To: <a href=3D"mailto:[email protected]= nt.net">[email protected]</a><br> > =A0 =A0 <mailto:<a href=3D"mailto:[email protected]">lcd= [email protected]</a>><br> > =A0 =A0 > =A0 =A0 <mailto:<a href=3D"mailto:[email protected]= tent.net">[email protected]</a><br> > =A0 =A0 <mailto:<a href=3D"mailto:[email protected]">lcd= [email protected]</a>>><br> > =A0 =A0 > =A0 =A0 <mailto:<a href=3D"mailto:[email protected]= tent.net">[email protected]</a><br> > =A0 =A0 <mailto:<a href=3D"mailto:[email protected]">lcd= [email protected]</a>><br> > =A0 =A0 > =A0 =A0 <mailto:<a href=3D"mailto:[email protected]= tent.net">[email protected]</a><br> > =A0 =A0 <mailto:<a href=3D"mailto:[email protected]">lcd= [email protected]</a>>>><br> > =A0 =A0 > =A0 =A0 ><br> > =A0 =A0 > =A0 =A0 ><br> > =A0 =A0 > =A0 =A0 > For your consideration, I have attached a v0= .5.6 patch which<br> > =A0 =A0 adds a<br> > =A0 =A0 > =A0 =A0 > driver for the Adafruit PiPlate<br> > =A0 =A0 (<a href=3D"http://adafruit.com/products/1109" target=3D"_blan= k">http://adafruit.com/products/1109</a>).<br> > =A0 =A0 > =A0 =A0 > =A0The PiPlate includes a HD44780 LCD and 5 = button keys which is<br> > =A0 =A0 > =A0 =A0 > accessed via a MCP23017 I2C IO expander.<br> > =A0 =A0 > =A0 =A0 ><br> > =A0 =A0 > =A0 =A0 > The driver was adapted from the HD44780-i2c = driver, which<br> > =A0 =A0 uses the<br> > =A0 =A0 > =A0 =A0 > PCF8574 I2C IO expander.<br> > =A0 =A0 > =A0 =A0 ><br> > =A0 =A0 > =A0 =A0 > Jon Brogdon<br> > =A0 =A0 > =A0 =A0 ><br> > =A0 =A0 ><br> > =A0 =A0 > =A0 =A0 Hi,<br> > =A0 =A0 ><br> > =A0 =A0 > =A0 =A0 please read [1]. Thank you.<br> > =A0 =A0 ><br> > =A0 =A0 > =A0 =A0 [1]<br> > =A0 =A0 <a href=3D"http://lcdproc.sourceforge.net/docs/current-dev.htm= l#code-style" target=3D"_blank">http://lcdproc.sourceforge.net/docs/current= -dev.html#code-style</a><br> > =A0 =A0 ><br> > =A0 =A0 > =A0 =A0 According to the schematic from [1], the pin for = blue<br> > =A0 =A0 backlight is on<br> > =A0 =A0 > =A0 =A0 GPB0, not on GPA8 (which does not exist anyway).<= br> > =A0 =A0 ><br> > =A0 =A0 > =A0 =A0 Is the schematic wrong or did I miss something?<b= r> > =A0 =A0 ><br> > =A0 =A0 > =A0 =A0 [2]<br> > =A0 =A0 ><br> > =A0 =A0 <a href=3D"http://learn.adafruit.com/system/assets/assets/000/= 003/861/original/pilcdplate.png?1360171818" target=3D"_blank">http://learn.= adafruit.com/system/assets/assets/000/003/861/original/pilcdplate.png?13601= 71818</a><br> > =A0 =A0 ><br> > =A0 =A0 > =A0 =A0 Regards,<br> > =A0 =A0 > =A0 =A0 Markus<br> > =A0 =A0 ><br> > =A0 =A0 > =A0 =A0 _______________________________________________<b= r> > =A0 =A0 > =A0 =A0 LCDproc mailing list<br> > =A0 =A0 > =A0 =A0 <a href=3D"mailto:[email protected]">L= [email protected]</a><br> > =A0 =A0 <mailto:<a href=3D"mailto:[email protected]">LCD= [email protected]</a>><br> </div></div>> =A0 =A0 <mailto:<a href=3D"mailto:[email protected]= ent.net">[email protected]</a><br> <div class=3D"im">> =A0 =A0 <mailto:<a href=3D"mailto:[email protected]= mnipotent.net">[email protected]</a>>><br> > =A0 =A0 > =A0 =A0 <a href=3D"http://lists.omnipotent.net/mailman/li= stinfo/lcdproc" target=3D"_blank">http://lists.omnipotent.net/mailman/listi= nfo/lcdproc</a><br> > =A0 =A0 ><br> > =A0 =A0 ><br> > =A0 =A0 ><br> > =A0 =A0 ><br> > =A0 =A0 ><br> > =A0 =A0 ><br> > =A0 =A0 > _______________________________________________<br> > =A0 =A0 > LCDproc mailing list<br> > =A0 =A0 > <a href=3D"mailto:[email protected]">LCDproc@l= ists.omnipotent.net</a> <mailto:<a href=3D"mailto:[email protected]= nt.net">[email protected]</a>><br> > =A0 =A0 > <a href=3D"http://lists.omnipotent.net/mailman/listinfo/l= cdproc" target=3D"_blank">http://lists.omnipotent.net/mailman/listinfo/lcdp= roc</a><br> ><br> > =A0 =A0 _______________________________________________<br> > =A0 =A0 LCDproc mailing list<br> </div>> =A0 =A0 <a href=3D"mailto:[email protected]">LCDproc@= lists.omnipotent.net</a> <mailto:<a href=3D"mailto:[email protected]= ent.net">[email protected]</a>><br> > =A0 =A0 <a href=3D"http://lists.omnipotent.net/mailman/listinfo/lcdpro= c" target=3D"_blank">http://lists.omnipotent.net/mailman/listinfo/lcdproc</= a><br> ><br> ><br> </blockquote></div><br></div> --f46d042ef753dd5f6e04d9dee05a-- --===============7643348188667407930== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ LCDproc mailing list [email protected] http://lists.omnipotent.net/mailman/listinfo/lcdproc --===============7643348188667407930==--