Re: [PATCH] add hd44780-spi driver

Hi,

thank you for your submission.

For future patches, you may want to use '-X diff_ignore' option which
excludes all automatically generated files. See [1].

I am familiar with the SPI mode of KS0073 and compatible as I used one
in some other project of mine [2]. However, I have never thought about
using SPI in LCDproc directly. First, because I'm not using Linux and
second because I had no machine with hardware support for SPI and
bit-banging this is not a viable option.

With machines like a Pi it makes sense to include this patch. I put that
on my TODO list.

I if remember well, the KS0073 need some special initialization if used
with 4 line displays and LCDproc already includes the code and an option
for it.

[1] http://lcdproc.sourceforge.net/docs/current-dev.html#submitting-code
[2]
http://mmdolze.users.sourceforge.net/using-lcdproc-with-spi-interfaces.html

Regards,
Markus


On 01.10.2013 10:26, [email protected] wrote:
> From: Simon Dawson <[email protected]>
>
> Add support for hd44780 compatible driver connected via SPI
>
> The patch has been tested using a EA DIP204-6 module, which contains a
> Samsung KS0073 driver. Should also work with the newer EA DIP203-6 module,
> which contains an SSD1803 driver.
>
> Not sure if there is too much KS0073-specific code in this for it to be
> acceptable as a general-purpose hd44780-spi driver...
>
> Signed-off-by: Simon Dawson <[email protected]>
> ---
>