Re: [PATCH] add hd44780-spi driver

Hi Markus; thanks for the feedback.

On 6 October 2013 23:55, Markus Dolze <[email protected]> wrote:
> For future patches, you may want to use '-X diff_ignore' option which
> excludes all automatically generated files. See [1].

Okay; sorry for the noise.

> I am familiar with the SPI mode of KS0073 and compatible as I used one
> in some other project of mine [2]. However, I have never thought about
> using SPI in LCDproc directly. First, because I'm not using Linux and
> second because I had no machine with hardware support for SPI and
> bit-banging this is not a viable option.
>
> With machines like a Pi it makes sense to include this patch. I put that
> on my TODO list.

Is there anything I can do to help with this? Is there anything
specific that I can do to improve my patch?

> I if remember well, the KS0073 need some special initialization if used
> with 4 line displays and LCDproc already includes the code and an option
> for it.

Yes, I had seen this code is in the common_init() function in hd44780.c

Simon.