Re: [patch]add the ksm infomation to linux pmda

Hi Ken,

----- Original Message -----
> On 23/01/17 20:48, Nathan Scott wrote:
> > ...
> > Thanks Liming - looks good to me.  I've updated QA & merged some small
> > additions too, if you could review my updates that would be great!
> 
> I'm seeing a failure in qa/821 with the additional mem.ksm metrics ...

Yeah, me too - my full QA run hadn't reached that test by the time I
shut up shop last night.

> The values for the mem.ksm metrics are all zero, but I see the data
> files used by qa/821 (meminfo-root-001.tgz and meminfo-root-002.tgz)
> contain _no_ sys/kernel/mm/ksm files).

*nod* - this is fine (these files predate ksm metrics & are not a full
sysfs snapshot).

> So should I just accept the new 821.out.bad as good (on the assumption
> that the mem.ksm metrics are being exercised elsewhere and zero is the
> correct value in the absence of the required stat files), or is some
> extension to the data files used in qa/821 required?

Accepting the .bad as the new good is the right thing to do here I think;
zero seems like an OK fallback value for all of these metrics.

cheers.

--
Nathan

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links:

You receive all messages sent to this group.

View/Reply Online (#15008): https://groups.io/g/pcp/message/15008
View All Messages In Topic (4): https://groups.io/g/pcp/topic/4218245
Mute This Topic: https://groups.io/mt/4218245?uid=174580
New Topic: https://groups.io/g/pcp/post
-=-=-
pcp mailing list
[email protected]
https://groups.io/g/pcp/messages
-=-=-
Change Your Subscription: https://groups.io/g/pcp/editsub?uid=174580
Group Home: https://groups.io/g/pcp
Contact Group Owner: [email protected]
Terms of Service: https://groups.io/static/tos
Unsubscribe: https://groups.io/g/pcp/leave/354243/563757577/xyzzy
-=-=-=-=-=-=-=-=-=-=-=-