[pcp:master] reported: perfevent_pmda: Add PMU events exported from kernel #github

--yabbadabbadoo
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable



[pcp:master] New Comment on Pull Request #277 perfevent_pmda: Add PMU event=
s exported from kernel ( https://github.com/performancecopilot/pcp/pull/277=
 )
By natoscott ( https://github.com/natoscott ) :

@hkshaw1990 yes, dots are OK as component separators within metric names -=
 just its not within a metric name component (this is a low level detail wh=
en adding metric names on the fly - wasn't clear if it will affect you here=
, so just thought I'd mention it). You can test this by ensuring the PMNS c=
an be expanded (e.g. via pminfo/pmprobe) at any point where this is a dot.

Regarding testing, you can have arbitrary complexity in a QA test via cust=
om qa/src code, then have the helper program produce deterministic "OK" out=
put if all is well and detailed diagnostics on failure. This still fits in =
with the "naive comparison" model just fine. In the perfevent case though, =
it may be overkill though - one can sometimes end up spending more time cha=
sing kernel/hardware issues, test workarounds and platform-idiosyncrasies t=
han doing useful testing - so, up to you to make a call there as the code a=
uthor.

The final thing to keep in mind is that there is likely to be other people=
 (like myself, and the other PCP maintainers) who run the tests frequently =
and will need to debug test failures. So there's a balance to be struck her=
e, it's not a one-size-fits all situation.



--yabbadabbadoo
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: quoted-printable





[pcp:master] New Comment on Pull Request <a href=3D"https://github.com/per=
formancecopilot/pcp/pull/277">#277 perfevent_pmda: Add PMU events exported =
from kernel</a><br>
By <a href=3D"https://github.com/natoscott">natoscott</a>:<p>
<p>@hkshaw1990 yes, dots are OK as component separators within metric name=
s - just its not within a metric name component (this is a low level detail=
 when adding metric names on the fly - wasn't clear if it will affect you h=
ere, so just thought I'd mention it).  You can test this by ensuring the PM=
NS can be expanded (e.g. via pminfo/pmprobe) at any point where this is a d=
ot.</p>

<p>Regarding testing, you can have arbitrary complexity in a QA test via c=
ustom qa/src code, then have the helper program produce deterministic &quot=
;OK&quot; output if all is well and detailed diagnostics on failure.  This =
still fits in with the &quot;naive comparison&quot; model just fine.  In th=
e perfevent case though, it may be overkill though - one can sometimes end =
up spending more time chasing kernel/hardware issues, test workarounds and =
platform-idiosyncrasies than doing useful testing - so, up to you to make a=
 call there as the code author.</p>

<p>The final thing to keep in mind is that there is likely to be other peo=
ple (like myself, and the other PCP maintainers) who run the tests frequent=
ly and will need to debug test failures.  So there's a balance to be struck=
 here, it's not a one-size-fits all situation.</p>



<p>


<div width=3D"1" style=3D"color:white;clear:both">_._,_._,_</div>
<hr>
Groups.io Links:<p>

You receive all messages sent to this group.


<p>

<a target=3D"_blank" href=3D"https://groups.io/g/pcp/message/15241">View/R=
eply Online (#15241)</a> |


  <a target=3D"_blank" href=3D"mailto:[email protected]?subject=3DRe:%20%5Bpcp=
%5D%20%5Bpcp%3Amaster%5D%20reported%3A%20perfevent_pmda%3A%20Add%20PMU%20ev=
ents%20exported%20from%20kernel%20%23github">Reply To Group</a>
  
    | <a target=3D"_blank" href=3D"mailto:?subject=3DRe:%20%5Bpcp%5D%20%5B=
pcp%3Amaster%5D%20reported%3A%20perfevent_pmda%3A%20Add%20PMU%20events%20ex=
ported%20from%20kernel%20%23github">Reply To Sender</a>
  


|


  <a target=3D"_blank" href=3D"https://groups.io/mt/4404698?uid=3D174580">=
Mute This Topic</a>
=20
| <a href=3D"https://groups.io/g/pcp/post">New Topic</a><br>



<a href=3D"https://groups.io/mk?hashtag=3Dgithub&subid=3D354243">Mute #git=
hub</a>

<p>

<p>pcp mailing list<br />[email protected]<br /><a href=3D"https://groups.io/g=
/pcp/messages" target=3D"_blank">https://groups.io/g/pcp/messages</a></p>

<a href=3D"https://groups.io/g/pcp/editsub?uid=3D174580">Change Your Subsc=
ription</a><br>
<a href=3D"https://groups.io/g/pcp">Group Home</a><br>
<a href=3D"mailto:[email protected]">Contact Group Owner</a><br>
<a href=3D"https://groups.io/static/tos">Terms Of Service</a><br>
<a href=3D"https://groups.io/g/pcp/leave/354243/563757577/xyzzy">Unsubscri=
be From This Group</a><br>

<div width=3D"1" style=3D"color:white;clear:both">_._,_._,_</div>


--yabbadabbadoo--