[speed:master] reported: github.com/performancecopilot/speed/bytewriter package does not compile on Windows. #github #golang

--yabbadabbadoo
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable



[speed:master] New Comment on Issue #37 github.com/performancecopilot/speed=
/bytewriter package does not compile on Windows. ( https://github.com/perfo=
rmancecopilot/speed/issues/37 )
By suyash ( https://github.com/suyash ) :

@saurvs vendoring x/sys might not be necessary, go ships with syscall.Crea=
teFileMapping on windows. The only thing to consider here is if we want to =
do the work ourselves or use a simpler solution ( https://github.com/edsrzf=
/mmap-go ( https://github.com/edsrzf/mmap-go ) , https://github.com/edsrzf/=
mmap-go/blob/master/mmap_windows.go#L25-L72 ( https://github.com/edsrzf/mma=
p-go/blob/master/mmap_windows.go#L25-L72 ) ).

Could you add the AppVeyor configuration separately, so failures can be ve=
rified.



--yabbadabbadoo
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: quoted-printable





[speed:master] New Comment on Issue <a href=3D"https://github.com/performa=
ncecopilot/speed/issues/37">#37 github.com/performancecopilot/speed/bytewri=
ter package does not compile on Windows.</a><br>
By <a href=3D"https://github.com/suyash">suyash</a>:<p>
<p>@saurvs vendoring <code>x/sys</code> might not be necessary, go ships w=
ith <code>syscall.CreateFileMapping</code> on windows. The only thing to co=
nsider here is if we want to do the work ourselves or use a simpler solutio=
n (<a href=3D"https://github.com/edsrzf/mmap-go" target=3D"_blank">https://=
github.com/edsrzf/mmap-go</a>, <a href=3D"https://github.com/edsrzf/mmap-go=
/blob/master/mmap_windows.go#L25-L72" target=3D"_blank">https://github.com/=
edsrzf/mmap-go/blob/master/mmap_windows.go#L25-L72</a>).</p>

<p>Could you add the AppVeyor configuration separately, so failures can be=
 verified.</p>



<p>


<div width=3D"1" style=3D"color:white;clear:both">_._,_._,_</div>
<hr>
Groups.io Links:<p>

You receive all messages sent to this group.


<p>

<a target=3D"_blank" href=3D"https://groups.io/g/pcp/message/15312">View/R=
eply Online (#15312)</a> |


  <a target=3D"_blank" href=3D"mailto:[email protected]?subject=3DRe:%20%5Bpcp=
%5D%20%5Bspeed%3Amaster%5D%20reported%3A%20github.com%2Fperformancecopilot%=
2Fspeed%2Fbytewriter%20package%20does%20not%20compile%20on%20Windows.%20%23=
github%20%23golang">Reply To Group</a>
  
    | <a target=3D"_blank" href=3D"mailto:?subject=3DRe:%20%5Bpcp%5D%20%5B=
speed%3Amaster%5D%20reported%3A%20github.com%2Fperformancecopilot%2Fspeed%2=
Fbytewriter%20package%20does%20not%20compile%20on%20Windows.%20%23github%20=
%23golang">Reply To Sender</a>
  


|


  <a target=3D"_blank" href=3D"https://groups.io/mt/4461426?uid=3D174580">=
Mute This Topic</a>
=20
| <a href=3D"https://groups.io/g/pcp/post">New Topic</a><br>



<a href=3D"https://groups.io/mk?hashtag=3Dgithub&subid=3D354243">Mute #git=
hub</a>

|
<a href=3D"https://groups.io/mk?hashtag=3Dgolang&subid=3D354243">Mute #gol=
ang</a>

<p>

<p>pcp mailing list<br />[email protected]<br /><a href=3D"https://groups.io/g=
/pcp/messages" target=3D"_blank">https://groups.io/g/pcp/messages</a></p>

<a href=3D"https://groups.io/g/pcp/editsub?uid=3D174580">Change Your Subsc=
ription</a><br>
<a href=3D"https://groups.io/g/pcp">Group Home</a><br>
<a href=3D"mailto:[email protected]">Contact Group Owner</a><br>
<a href=3D"https://groups.io/static/tos">Terms Of Service</a><br>
<a href=3D"https://groups.io/g/pcp/leave/354243/563757577/xyzzy">Unsubscri=
be From This Group</a><br>

<div width=3D"1" style=3D"color:white;clear:both">_._,_._,_</div>


--yabbadabbadoo--