[speed:master] reported: Allow external configuration of logger #github #golang

--yabbadabbadoo
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable



[speed:master] New Comment on Issue #36 Allow external configuration of log=
ger ( https://github.com/performancecopilot/speed/issues/36 )
By suyash ( https://github.com/suyash ) :

@lzap there seem to be 2 solutions to this

*=20

We set all the logging configuration here ( https://github.com/performance=
copilot/speed/blob/master/speed.go#L25-L29 ( https://github.com/performance=
copilot/speed/blob/master/speed.go#L25-L29 ) ). We could allow the user to =
configure Formatter and Level

*=20

We can allow the user to set a custom function, something like var Logger =
func(string, ...interface{}) and use that as the logging function.

@natoscott any other ideas on this?



--yabbadabbadoo
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: quoted-printable





[speed:master] New Comment on Issue <a href=3D"https://github.com/performa=
ncecopilot/speed/issues/36">#36 Allow external configuration of logger</a><=
br>
By <a href=3D"https://github.com/suyash">suyash</a>:<p>
<p>@lzap there seem to be 2 solutions to this</p>

<ol>
<li><p>We set all the logging configuration here (<a href=3D"https://githu=
b.com/performancecopilot/speed/blob/master/speed.go#L25-L29" target=3D"_bla=
nk">https://github.com/performancecopilot/speed/blob/master/speed.go#L25-L2=
9</a>). We could allow the user to configure <code>Formatter</code> and <co=
de>Level</code></p></li>

<li><p>We can allow the user to set a custom function, something like
<code>
var Logger func(string, ...interface{})
</code>
and use that as the logging function.</p></li>
</ol>

<p>@natoscott any other ideas on this?</p>



<p>


<div width=3D"1" style=3D"color:white;clear:both">_._,_._,_</div>
<hr>
Groups.io Links:<p>

You receive all messages sent to this group.


<p>

<a target=3D"_blank" href=3D"https://groups.io/g/pcp/message/15313">View/R=
eply Online (#15313)</a> |


  <a target=3D"_blank" href=3D"mailto:[email protected]?subject=3DRe:%20%5Bpcp=
%5D%20%5Bspeed%3Amaster%5D%20reported%3A%20Allow%20external%20configuration=
%20of%20logger%20%23github%20%23golang">Reply To Group</a>
  
    | <a target=3D"_blank" href=3D"mailto:?subject=3DRe:%20%5Bpcp%5D%20%5B=
speed%3Amaster%5D%20reported%3A%20Allow%20external%20configuration%20of%20l=
ogger%20%23github%20%23golang">Reply To Sender</a>
  


|


  <a target=3D"_blank" href=3D"https://groups.io/mt/4462520?uid=3D174580">=
Mute This Topic</a>
=20
| <a href=3D"https://groups.io/g/pcp/post">New Topic</a><br>



<a href=3D"https://groups.io/mk?hashtag=3Dgolang&subid=3D354243">Mute #gol=
ang</a>

|
<a href=3D"https://groups.io/mk?hashtag=3Dgithub&subid=3D354243">Mute #git=
hub</a>

<p>

<p>pcp mailing list<br />[email protected]<br /><a href=3D"https://groups.io/g=
/pcp/messages" target=3D"_blank">https://groups.io/g/pcp/messages</a></p>

<a href=3D"https://groups.io/g/pcp/editsub?uid=3D174580">Change Your Subsc=
ription</a><br>
<a href=3D"https://groups.io/g/pcp">Group Home</a><br>
<a href=3D"mailto:[email protected]">Contact Group Owner</a><br>
<a href=3D"https://groups.io/static/tos">Terms Of Service</a><br>
<a href=3D"https://groups.io/g/pcp/leave/354243/563757577/xyzzy">Unsubscri=
be From This Group</a><br>

<div width=3D"1" style=3D"color:white;clear:both">_._,_._,_</div>


--yabbadabbadoo--