[bug-gnulib] bug in gl_FUNC_MKSTEMP

--+HP7ph2BbKc20aGI
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

Hello,
  the texinfo bug report cited below has inspired me to the following two
bug reports:

1) gl_FUNC_MKSTEMP in m4/mkstemp.m4 should clean up the temporary files.
Would the patch attached to this mail be OK?

2) Why does the template use the long prefix "conftest"?  Shouldn't we use
2-4 letter prefix, as suggested in the comment to the source to AS_TMPDIR
in autoconf/lib/m4sugar/m4sh.m4 ?

Yours,
	Stepan Kasal

----------
From: "Juan Manuel Guerrero" <[email protected]>
To: [email protected]
Date: Fri, 17 Dec 2004 20:28:48 +0200
Subject: [texinfo-pretest] djgpp specific patch for 4.7.92

Here one more djgpp specific adjustment.

Regards,
Juan M. Guerrero

2004-12-17  Juan M. Guerrero  <[email protected]>

	* djgpp/config.bat: remove files like coXXXXXX.tmp created
	in the top_srcdir by the gl_FUNC_MKSTEMP test.

diff -apruNU5 texinfo-4.7.92.orig/djgpp/config.bat texinfo-4.7.92/djgpp/config.bat
--- texinfo-4.7.92.orig/djgpp/config.bat	2002-09-26 22:01:10.000000000 +0000
+++ texinfo-4.7.92/djgpp/config.bat	2004-12-17 03:48:10.000000000 +0000
@@ -204,10 +204,13 @@ echo --disable-nls >> arguments
 :configure_package
 echo Running the ./configure script...
 sh ./configure @arguments
 if errorlevel 1 goto cfg_error
 rm arguments
+
+Rem Remove files created by the gl_FUNC_MKSTEMP test.
+rm co*.tmp
 echo Done.
 goto End
 
 :sed_error
 echo ./configure script editing failed!
----- End forwarded message -----

--+HP7ph2BbKc20aGI
Content-Type: text/plain; charset=us-ascii
Content-Disposition: attachment; filename="gnulib-20041220-mkstemp.patch"

2004-12-20  Stepan Kasal  <[email protected]>

	* m4/mkstemp.m4 (gl_FUNC_MKSTEMP): Change the template to
	  ``conftestXXXXXX.tmp'' and remove the files at the end.

Index: m4/mkstemp.m4
===================================================================
RCS file: /cvsroot/gnulib/gnulib/m4/mkstemp.m4,v
retrieving revision 1.11
diff -u -r1.11 mkstemp.m4
--- m4/mkstemp.m4	20 Apr 2004 09:05:49 -0000	1.11
+++ m4/mkstemp.m4	20 Dec 2004 09:33:15 -0000
@@ -22,7 +22,7 @@
 	    int i;
 	    for (i = 0; i < 70; i++)
 	      {
-		char template[] = "conftestXXXXXX";
+		char template[] = "conftestXXXXXX.tmp";
 		int fd = mkstemp (template);
 		if (fd == -1)
 		  exit (1);
@@ -35,6 +35,7 @@
 	gl_cv_func_mkstemp_limitations=yes,
 	gl_cv_func_mkstemp_limitations=yes
 	)
+	rm -f conftest*.tmp
       ]
     )
   fi

--+HP7ph2BbKc20aGI
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
Texinfo home page: http://www.gnu.org/software/texinfo/
[email protected]
http://ff0.org/mailman/listinfo/texinfo-pretest

--+HP7ph2BbKc20aGI--