Re: Re: rewrote tests in unittest/ to python unittests

Bram Moolenaar <[email protected]>
Newsgroups gmane.comp.tools.aap.devel
Message-ID <[email protected]>
Joerg Beyer wrote:

> > > Bram Moolenaar wrote:
> > > > Joerg Beyer wrote:
> > > 
> > > > Would it be acceptable that running the tests installs unittest.py
> > > > automatically?  We should probably ask the user if he really
> > > > wants to do this.  That's very much what the package installer
> > > > already handles.
> > > 
> > > I would suggest it this way: If the unittests fail because the
> > > module is not installed (import error), then we can emit an error
> > > message that tells "unittest module is missing, run 'aap
> > > install_unittest' to install it. This will download some python
> > > code from sf.net".
> > 
> > That would be "aap --install unittest".
> > 
> > Still, doing it directly avoids that the user has to type this command.
> > Is there something against doing that?
> 
> You wrote, that you think about asking the user and I think that
> is a good idea, since to some programs have a bad reputation for
> initiating internet connections without asking. My idea was, instead
> of printing a question and promting for some input (reading from
> stdin), just stop with an message that tells the user, why the unittest
> are not working and tell him, which aap command to use to
> fix that.

Well, letting the user type a command while we can do the work for him
isn't te best solution.

This is just a simple thing, I'll add the code to download unittest.py
when the user wants to do this.

-- 
hundred-and-one symptoms of being an internet addict:
44. Your friends no longer send you e-mail...they just log on to your IRC
    channel.

 /// Bram Moolenaar -- [email protected] -- http://www.Moolenaar.net   \\\
///          Creator of Vim - Vi IMproved -- http://www.Vim.org          \\\
\\\              Project leader for A-A-P -- http://www.A-A-P.org        ///
 \\\  Help AIDS victims, buy here: http://ICCF-Holland.org/click1.html  ///


-------------------------------------------------------
This SF.Net email sponsored by: Free pre-built ASP.NET sites including
Data Reports, E-commerce, Portals, and Forums are available now.
Download today and enter to win an XBOX or Visual Studio .NET.
http://aspnet.click-url.com/go/psa00100003ave/direct;at.aspnet_072303_01/01
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.