normalizing variable names

Adriaan de Groot <adridg-FlD2LfDziEhmR6Xm/[email protected]>
Newsgroups gmane.comp.tools.aap.devel
Message-ID <[email protected]>
the qt module sets the variable qt_includedir to the value of Qt's include 
dir. Gosh, that's really mutiply redundant. Especially when accessing it as 
$m_qt.qt_includedir. The attached patch changes the variable name to plain 
includedir, where the module scope is used to distinguish it from other 
includedirs folks may have ($m_kde.includedir and $m_qt.includedir come to 
mind). 

Now,. I know we had a discussion about variable naming. I don't know if this 
kind of "read only" variable (it's not used elsewhere, it's just a 
convenience for the user who can write INCLUDE += -I$m_qt.includedir), falls 
under the existing norms.

-- 
pub  1024D/FEA2A3FE 2002-06-18 Adriaan de Groot <[email protected]>
            If the door is ajar, can we fill it with door-jamb?
qt.diff (text/x-diff, 535 B)
Index: modules/qt.aap
===================================================================
RCS file: /cvsroot/a-a-p/Exec/modules/qt.aap,v
retrieving revision 1.2
diff -u -3 -p -r1.2 qt.aap
--- modules/qt.aap	9 Oct 2003 20:55:06 -0000	1.2
+++ modules/qt.aap	13 Oct 2003 21:45:28 -0000
@@ -21,7 +21,9 @@ moc = $QTDIR/bin/moc
 @if not os.path.isfile(moc):
   :error moc ($moc) is not executable.
 
-qt_includedir = $QTDIR/include
+includedir = $QTDIR/include
+libdir = $QTDIR/lib
+bindir = $QTDIR/bin
 
 # Filetypes in Qt & KDE
 :filetype
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.