Re: [PATCH] Make large enum constants unsigned

Stefan Kristiansson <[email protected]> Thu, 22 May 2014 20:34:40 +0300
Newsgroups gmane.comp.tools.cgen.devel
Message-ID <CADzBsGN3U6a3BS5L7o7DYh_4KTghEXnB2UE0XKdNZrAN=A0p=g@mail.gmail.com>
On Thu, May 22, 2014 at 6:09 PM, Frank Ch. Eigler <[email protected]> wrote:
> Have you thought of having cgen emit it as
>
>      (string-append "(signed int)" (number->string (cadr e)))
>

Ignoring the 'string-upcase' that would turn that into "(SIGNED INT)",
how would that be better than?

      (string-append (number->string (cadr e)) "U")


I dismissed that, since it would create a lot larger diff in generated
files than in the isolated cases where it's actually a problem.

> ... or even find a number->string conversion function that takes into
> account the destionation language's encoding constraints.
>

That might certainly be an option, but way over my current Scheme capabilities.
If you give me some pointers I could try to improve them.

Stefan