Re: [PATCH] Make large enum constants unsigned
"Frank Ch. Eigler" <[email protected]> Thu, 22 May 2014 17:06:21 -0400
| Newsgroups | gmane.comp.tools.cgen.devel |
|---|---|
| Message-ID | <[email protected]> |
Hi - > > (string-append "(signed int)" (number->string (cadr e))) > [...] > how would that be better than? > (string-append (number->string (cadr e)) "U") It would be a closer match to expressing our desire to match C enum typing, but I'd be fine with "U" suffixing too. > I dismissed that, since it would create a lot larger diff in generated > files than in the isolated cases where it's actually a problem. [...] IMHO, that's not such a big deal. We don't usually look closely at the diffs of generated files, once the generating tools are trustworthy. - FChE