RE: Re: difference between LaunchViewer and LaunchEditor?
"Oliver Giesen" <[email protected]>
| Newsgroups | gmane.comp.version-control.cvs.gui.devel |
|---|---|
| Message-ID | <H0000067000416d6.1070875406.mail01.lucatec.de@MHS> |
> I'll check tomorrow on my work machine) Done now. Works as expected here. Graph integration still needs some polishing work: The current shortcuts are inconsistent and the new items for opening are still missing. I also really think the special handling of extension-less files for the "open" action can be scrapped now that double-click uses "edit"/default editor. The whole point of the special handling was to be able to double-click to view in the default editor, wasn't it (for non-Windows-users: special handling was necessary because, as the whole file-type-association mechanism is based on file name extensions, extension-less files could not be persistently associated, therefore in the old scheme, "open"ing extension-less files would always either fail or trigger the OS' "Open with..." dialog)? > reducing it to "ShellAction" seems a bit _too_ > generic or isn't > it? On hind sight I don't think it's that bad anymore. Alternatively, what about PerformShellAction or ShellActOn? === > I implemented LaunchViewer and LaunchEditor just last week to > allow the > annotate command to work in MacCvs, so it _is_ cross-platform > code now > ;-) D'Oh! As I wrote, I was working against the WINCVS13b15 tag so I didn't see your changes yet... Any ideas on approaching this? Should the ShellAction function move back to CvsCommands or where else? Probably the result of it should be cast to UINT right away in that case. Thinking about it, it doesn't make any sense returning a HINSTANCE even for the Windows-only implementation (the docs say it's only of that type for backward-compatibility reasons - it's never an actual instance handle at all). What kind of return would you get from the *ix/Mac-equivalent of ShellAction? Is there an equivalent at all? Put differently: Is there a standard OS-level mechanism to distiguish between different ways to act on files/folders, specifically between editing and viewing them (there has to be, hasn't it - they probably don't say MS hasn't ever come up with anything original for nothing, don't they? ;) ). Cheers, Oliver ---- ------------------ JID: [email protected] ICQ: 18777742 (http://wwp.icq.com/18777742) ------------------------ Yahoo! Groups Sponsor ---------------------~--> Buy Ink Cartridges or Refill Kits for your HP, Epson, Canon or Lexmark Printer at MyInks.com. Free s/h on orders $50 or more to the US & Canada. http://www.c1tracking.com/l.asp?cid=5511 http://us.click.yahoo.com/mOAaAA/3exGAA/qnsNAA/NhFolB/TM ---------------------------------------------------------------------~-> To unsubscribe from this group, send an email to: [email protected] Your use of Yahoo! Groups is subject to http://docs.yahoo.com/info/terms/