RE: Re: difference between LaunchViewer and LaunchEditor?

"kaczoroj" wrote:

> > The current shortcuts are inconsistent and the new items 
> > for opening are still missing.
> 
> You can safely ignore the shortcuts for now ;)

OK. No prob. It'd be nice however if I had a solution for the no longer 
functioning Enter in the console pane for the meantime... any idea?

 
> > I also really think the special handling of extension-less files 
> > for the "open" action can be scrapped now that double-click uses 
> > "edit"/default editor. 
> 
> That depends on what happens when shell "edit" verb is used against 
> the extensionless file...

Well, that's easy and already taken care of. If "edit" fails (remember, 
there won't be too many file types that have got this defined in the 
first place), then the default editor is launched. That was kind of the 
point of it all... ;)


> ShellAction sounds good to me.

Fine, will rename.

 
> > D'Oh! As I wrote, I was working against the WINCVS13b15 tag so 
> > I didn't see your changes yet... 
> 
> Please bare with me - I will make the WinCvs Alert changes in a
> couple of days and you can update to the latest then ;)

No worries. After all, *I*'ve got my working shell edit 
implementation... ;)


> > Any ideas on approaching this? Should the ShellAction function move 
> > back to CvsCommands or where else? 
> 
> It seems to me that we could merge the LaunchEditor and LaunchViewer 
> by introducing the "LaunchType" parameter (enum) and then use a
> switch statement to execute appropriate code. That way it's easy to
> extend the function to add new types or platform-specific types.

There will not be a lot to merge. Pulling out the ShellExecute stuff 
into the new ShellAction function pretty much took care of most of the 
duplication. However a unified and extendable interface defintitely 
makes sense.

Cheers,

-- 
Oliver
----  ------------------
JID:  [email protected]
ICQ:  18777742     (http://wwp.icq.com/18777742)


------------------------ Yahoo! Groups Sponsor ---------------------~-->
Buy Ink Cartridges or Refill Kits for your HP, Epson, Canon or Lexmark
Printer at MyInks.com. Free s/h on orders $50 or more to the US & Canada.
http://www.c1tracking.com/l.asp?cid=5511
http://us.click.yahoo.com/mOAaAA/3exGAA/qnsNAA/NhFolB/TM
---------------------------------------------------------------------~->

To unsubscribe from this group, send an email to:
[email protected]

 

Your use of Yahoo! Groups is subject to http://docs.yahoo.com/info/terms/