Re: difference between LaunchViewer and LaunchEditor?

"kaczoroj" <[email protected]>
Newsgroups gmane.comp.version-control.cvs.gui.devel
Message-ID <[email protected]>
Oliver,

> The current shortcuts are inconsistent and the new items 
> for opening are still missing.

You can safely ignore the shortcuts for now ;)

> I also really think the special handling of extension-less files 
> for the "open" action can be scrapped now that double-click uses 
> "edit"/default editor. 

That depends on what happens when shell "edit" verb is used against 
the extensionless file...

> > reducing it to "ShellAction" seems a bit _too_ 
> > generic or isn't
> > it?
> 
> On hind sight I don't think it's that bad anymore. 
> Alternatively, what about PerformShellAction or ShellActOn?

ShellAction sounds good to me.

> D'Oh! As I wrote, I was working against the WINCVS13b15 tag so 
> I didn't see your changes yet... 

Please bare with me - I will make the WinCvs Alert changes in a couple 
of days and you can update to the latest then ;)


> Any ideas on approaching this? Should the ShellAction function move 
> back to CvsCommands or where else? 

It seems to me that we could merge the LaunchEditor and LaunchViewer 
by introducing the "LaunchType" parameter (enum) and then use a switch 
statement to execute appropriate code. That way it's easy to extend 
the function to add new types or platform-specific types.

Best Regards,
Jerzy


------------------------ Yahoo! Groups Sponsor ---------------------~-->
Buy Ink Cartridges or Refill Kits for your HP, Epson, Canon or Lexmark
Printer at MyInks.com. Free s/h on orders $50 or more to the US & Canada.
http://www.c1tracking.com/l.asp?cid=5511
http://us.click.yahoo.com/mOAaAA/3exGAA/qnsNAA/NhFolB/TM
---------------------------------------------------------------------~->

To unsubscribe from this group, send an email to:
[email protected]

 

Your use of Yahoo! Groups is subject to http://docs.yahoo.com/info/terms/
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.