WinCvs/GraphView.cpp code review

I had checked WinCvs/GraphView.cpp changed by Jerzy.
I can point out two things.

(1)If we want to treat VK_ESC, we have to use PreTranslateMessage,
   maybe.
(2)Though it depends on your intent, but if you simply want to
   navigate for multiple selection by using Ctrl+Shift+arrows,
   in following code:
  ----------------------------
  /*__*/if( !shiftOn )
  /*__*/{
  /*____*/CWinLogData* data = (CWinLogData*)node->GetUserData();
  /*____*/data->UnselectAll(this);
  /*__*/}
  ----------------------------
  you have no need to call UnselectAll. (It causes decreasing 
  performance.)

# If you are going to support selections more than two,
# we should consider changing design of TGraphCurSelector
# to manage selection using std::vector, etc. e.g.
# "std::vector<CLogNode*> m_sels;". (Instead of GetSel1, GetSel2,
# we will use like "GetSels().begin() ~ GetSels().end()"...)



 

------------------------ Yahoo! Groups Sponsor ---------------------~-->
Upgrade to 128-bit SSL Security!
http://us.click.yahoo.com/qZ0LdD/yjVHAA/TtwFAA/NhFolB/TM
---------------------------------------------------------------------~->

Yahoo! Groups Links

To visit your group on the web, go to:
 http://groups.yahoo.com/group/cvsgui-dev/

To unsubscribe from this group, send an email to:
 [email protected]

Your use of Yahoo! Groups is subject to:
 http://docs.yahoo.com/info/terms/