Re: Cmd handling in rf/gCvs

Karl-Heinz BrĂ¼nen <[email protected]> Tue, 29 Jun 2004 10:31:37 +0200
Newsgroups gmane.comp.version-control.cvs.gui.devel
Message-ID <[email protected]>
Hi Richard,

Richard Wirth wrote:

> Hello Karl-Heinz,
>
>   Is there any reason why almost all the cmd handlers are implemented
>   twice (once in UCvsFolders and once in UCvsFrame)????

AFAIK, there shouldn't be a reason.

>   And the implementation is identical and doesn't depend on any member
>   of UCvsFiles or UCvsFolders resp.!
>   So why not to move these handlers to UCvsFrame?

I have moved some functions some time ago, but didn't do it for all. The 
"Traversal"-Stuff is also a candidate for this. I had started on that 
topic, but some more important work comes, so I stopped it and haven't 
restarted the work yet. If you're interested, I can send you the 
modified files.

>   There we only need one implementation, and we can easily decide
>   whether to execute the cmd on Files view or Folders view.
>   So if there is no contradiction, I'll move the handlers to UCvsFrame
>   and modify the interface of UCvsFiles and UCvsFolders accordingly
>   (only handlers to query/process selection required than).
>
>   Btw.: I haven't yet understood how the selection processing for
>   Python implementation should work. As far as I see, the Windows
>   implementaion bypasses the rf completely (?). The use of gUICache is
>   not clear. So can anybody explain how it should be used?

Welcome in the club ;)

Best Regards,

Kalle


------------------------ Yahoo! Groups Sponsor --------------------~--> 
Yahoo! Domains - Claim yours for only $14.70
http://us.click.yahoo.com/Z1wmxD/DREIAA/yQLSAA/NhFolB/TM
--------------------------------------------------------------------~-> 

 
Yahoo! Groups Links

<*> To visit your group on the web, go to:
     http://groups.yahoo.com/group/cvsgui-dev/

<*> To unsubscribe from this group, send an email to:
     [email protected]

<*> Your use of Yahoo! Groups is subject to:
     http://docs.yahoo.com/info/terms/