RFE #684718

"Oliver Giesen" <[email protected]> Sun, 4 Jul 2004 16:59:07 +0200
Newsgroups gmane.comp.version-control.cvs.gui.devel
Message-ID <001001c461d7$75266550$4701a8c0@g01>
I'm currently implementing RFE #684718
(https://sourceforge.net/tracker/?func=detail&atid=360072&aid=684718&group_i
d=10072). The behaviour is already pretty much what I expected but I'm still
not happy about some details of the implementation, especially the fact that
currently the indices of the individual status bar panes are hardcoded. The
recommended practice according to some documents I found on MSDN would be to
use unique resource IDs for each pane (those could then be converted to the
pane indices using the CommandToIndex method) but when I tried that WinCvs
would suddenly not even start up anymore. I have close to no experience with
MFC/C++ programming apart from the few patches I did so far, so there's
obviously some semantics linked to resource IDs that I'm missing and which I
didn't cater for. Could maybe anyone enlight me?
Alternatively, I have been thinking about storing the pane indices in an
enumeration structure of our own.That way we wouldn't even have to call
CommandToIndex anymore... acceptable?

Another thing I had been planning to do but am not entirely sure about
anymore is implementing some kind of logic for truncating the Root and
Repository strings in a way that they still maintain a certain level of
information even when their respective panes are too narrow to display them
completely, using the common approach of replacing the truncated part with
"...". Now that I've been working with my patched version (that does not yet
contain any such functionality) for a while I have been wondering if this
really makes sense and if it does which part of the strings should be
maintained, e.g. which of the following truncated CVSROOTs would still be
the most informative:

a) :pserver:[email protected]:/cv... (simply truncate at end)
b) :pserver:[email protected].../cvsgui (maintain as much of path from the
end as possible)
c) [email protected]:/cvsroot/cvsgui (truncate at start)
d) :pserver:...cvs.sf.net:/cvsroot/cvsgui (maintain protocol prefix)
...

Comments?

P.S.: For anyone looking at the patch attached to the report, I already
noticed that there still was a delete pSandboxInfo missing.

Cheers,

Oliver
----  ------------------
JID:  [email protected]
ICQ:  18777742     (http://wwp.icq.com/18777742)



------------------------ Yahoo! Groups Sponsor --------------------~--> 
Yahoo! Domains - Claim yours for only $14.70
http://us.click.yahoo.com/Z1wmxD/DREIAA/yQLSAA/NhFolB/TM
--------------------------------------------------------------------~-> 

 
Yahoo! Groups Links

<*> To visit your group on the web, go to:
    http://groups.yahoo.com/group/cvsgui-dev/

<*> To unsubscribe from this group, send an email to:
    [email protected]

<*> Your use of Yahoo! Groups is subject to:
    http://docs.yahoo.com/info/terms/