Why only show branch tags for directories?
"Oliver Giesen" <[email protected]> Fri, 11 Feb 2005 14:26:13 +0100
| Newsgroups | gmane.comp.version-control.cvs.gui.devel |
|---|---|
| Message-ID | <H0000067000e2de4.1108128373.mail01.lucatec.de@MHS> |
I have just spent some time investigating an issue reported on the
cvsgui list about tags sometimes not showing up for directories (see
http://groups.yahoo.com/group/cvsgui/message/15433 or
nntp://news.cvsnt.org/support.cvsgui/10819).
I have identified the relevant code in CvsEntries.cpp, lines 1033-1041:
if( (line_length = getline(&line, &line_chars_allocated, fpin)) > 0 )
{
char* tmp = strchr(line, '\n');
if( tmp != NULL )
*tmp = '\0';
if( line[0] == 'T' )
tag = line + 1;
}
Is this deliberate? What about sticky tags (N) and dates (D)? Why not
display them if CVS records them?
How about simply changing the above to this:
if( (line_length = getline(&line, &line_chars_allocated, fpin)) > 1 )
{
char* tmp = strchr(line, '\n');
if( tmp != NULL )
*tmp = '\0';
tag = line + 1;
}
(BTW: What is this stuff about tmp in there? It doesn't appear to be
used anywhere...)
Comments?
Oliver
---- ------------------
JID: [email protected]
MSN: [email protected]
ICQ: 18777742 (http://wwp.icq.com/18777742)
Yahoo! Groups Links
<*> To visit your group on the web, go to:
http://groups.yahoo.com/group/cvsgui-dev/
<*> To unsubscribe from this group, send an email to:
[email protected]
<*> Your use of Yahoo! Groups is subject to:
http://docs.yahoo.com/info/terms/