Re: Why only show branch tags for directories?

Hello Oliver,

Friday, February 11, 2005, 2:26:13 PM, you wrote:


OG> I have just spent some time investigating an issue reported on the
OG> cvsgui list about tags sometimes not showing up for directories (see
OG> http://groups.yahoo.com/group/cvsgui/message/15433 or 
OG> nntp://news.cvsnt.org/support.cvsgui/10819).

OG> I have identified the relevant code in CvsEntries.cpp, lines 1033-1041:

OG> if( (line_length = getline(&line, &line_chars_allocated, fpin)) > 0 )
OG> {
OG> 	char* tmp = strchr(line, '\n');
OG> 	if( tmp != NULL )
OG> 		*tmp = '\0';
	
OG> 	if( line[0] == 'T' )
OG> 		tag = line + 1;
OG> }

OG> Is this deliberate? What about sticky tags (N) and dates (D)? Why not
OG> display them if CVS records them?

As Bo stated, only BranchTags make sense to show for directories. And
I think he is right there.

OG> (BTW: What is this stuff about tmp in there? It doesn't appear to be
OG> used anywhere...)

strstr() returns the pointer to the '\n' (line delimiter) here.
 '*tmp = 0' set's an EndOfStringMarker (cut's the line delimiter).
That's correct and necessary here, cause we only want the tag without
a newline apended.


-- 
Best regards,
 Richard                            mailto:[email protected]



 
Yahoo! Groups Links

<*> To visit your group on the web, go to:
    http://groups.yahoo.com/group/cvsgui-dev/

<*> To unsubscribe from this group, send an email to:
    [email protected]

<*> Your use of Yahoo! Groups is subject to:
    http://docs.yahoo.com/info/terms/