Re: array new[] bug in Utils/StringUtils.cpp

Adrian Buehlmann wrote:
> Hi all
>
> (this is intended for the TortoiseCVS developers, sorry if this is the wrong list
> -- I haven't found a -devel list)
>
> We seem to have been taken the StringUtils.cpp of TortoiseCVS for TortoiseHg [1].
>
> I noticed there is an array new / delete bug in WideToMultibyte and MultibyteToWide
> (new[] must be paired with delete[], which is not).
You are correct, of course - auto_ptr is a poor choice in this case. I 
would prefer boost::scoped_array, but since Boost is not a prerequisite 
for TortoiseCVS, I will probably use another solution.

Thanks for pointing this out.

-Torsten

------------------------------------------------------------------------------
Are you an open source citizen? Join us for the Open Source Bridge conference!
Portland, OR, June 17-19. Two days of sessions, one day of unconference: $250.
Need another reason to go? 24-hour hacker lounge. Register today!
http://ad.doubleclick.net/clk;215844324;13503038;v?http://opensourcebridge.org