Re: [viewvc-dev] svn commit: r2626 - branches/property-diff: lib templates

On Monday, October 17, 2011 10:02:35 am C. Michael Pilato wrote:
> On 10/17/2011 12:44 PM, Alexey Neyman wrote:
> > On Monday, October 17, 2011 08:37:21 am C. Michael Pilato wrote:
> >> Hrm...  we might want to think through this one a bit.  Will this same
> >> URL format grow into a fully recursive directory diff in the future? 
> >> Do we anticipate the need for specifying the depth of a directory diff
> >> (recursive/non-recursive, depth-zero/depth-infinity, etc.)?
> > 
> > Yes, I thought "&recursive=1" would be selecting the recursive diff, and
> > the
> > 
> > link would look like:
> >   Diff to previous 1234 (recursive)
> > 
> > Where "previous 1234" links to a diff of the directory itself (as it does
> > now) and "recursive" links to the, eh, recursive diff.
> 
> What do you think is more intuitive, that a directory diff URL without a
> recursive-ness specifier included would be recursive, or that it would be
> non-recursive?  I kinda think that recursive operation should be the
> default, especially since Subversion is unique in that it offers some
> non-trivial meaning to the phrase "non-recursive directory diff" (because
> it actually has something to diff in such scenarios: properties).

There are two issues here:
- Default "recursiveness" for a directory diff
- Link formatting

I don't have a strong opinion on the default "recursiveness" setting. Are you 
suggesting to put "&recursive=0" to current URLs so that the default view is 
recursive and the meaning of the URLs remains the same once recursive diff is 
introduced?

As to link formatting, my concern is that recursive diff may be quite large 
(e.g. if performed on a large check-in at the top-of-project directory). 
Setting it out as a separate option in parentheses is, to some extent, a mild 
warning, sort of "do-you-really-want-it". It also makes it easier for 
templates to disable such links conditionally.

Regards,
Alexey.

------------------------------------------------------
http://viewvc.tigris.org/ds/viewMessage.do?dsForumId=4251&dsMessageId=2857815

To unsubscribe from this discussion, e-mail: [[email protected]].