Re: [viewvc-dev] svn commit: r2625 - branches/property-diff: lib templates templates/include

On Monday, October 17, 2011 08:32:29 am C. Michael Pilato wrote:
> On 10/16/2011 02:50 PM, [email protected] wrote:
> > Author: stilor
> > Date: 2011-10-16 11:50:08-0700
> > New Revision: 2625
> 
> [...]
> 
> > Url:
> > http://viewvc.tigris.org/source/browse/viewvc/branches/property-diff/tem
> > plates/include/diff_display.ezt?view=diff&pathrev=2625&r1=2624&r2=2625
> > ========================================================================
> > ====== ---
> > branches/property-diff/templates/include/diff_display.ezt	(original) +++
> > branches/property-diff/templates/include/diff_display.ezt	2011-10-16
> > 11:50:08-0700 @@ -1,3 +1,6 @@
> > +[is diff.display_as "anchor"]
> > +  <a name="[diff.anchor]"></a>
> > +[else]
> 
> The use of <a name=""></a> is not strictly XHTML-compliant.  We'll want to
> attach the anchor as an "id" attribute value to another tag instead (and,
> of course, do our best to ensure it's uniqueness).

Ok, replaced it with <p id=""/>. As to uniqueness, the current diff view only 
generates two anchors - "content" and "properties". There may be more when 
recursive diff is supported - although I haven't yet decided if we need 
anchors pointing to a particular path inside a recursive diff.

Regards,
Alexey.

------------------------------------------------------
http://viewvc.tigris.org/ds/viewMessage.do?dsForumId=4251&dsMessageId=2857854

To unsubscribe from this discussion, e-mail: [[email protected]].