Re: [viewvc-dev] svn commit: r2626 - branches/property-diff: lib templates

On Monday, October 17, 2011 12:31:16 pm C. Michael Pilato wrote:
> On 10/17/2011 01:19 PM, Alexey Neyman wrote:
> > On Monday, October 17, 2011 10:02:35 am C. Michael Pilato wrote:
> >> What do you think is more intuitive, that a directory diff URL without a
> >> recursive-ness specifier included would be recursive, or that it would
> >> be non-recursive?  I kinda think that recursive operation should be the
> >> default, especially since Subversion is unique in that it offers some
> >> non-trivial meaning to the phrase "non-recursive directory diff"
> >> (because it actually has something to diff in such scenarios:
> >> properties).
> > 
> > There are two issues here:
> > - Default "recursiveness" for a directory diff
> > - Link formatting
> > 
> > I don't have a strong opinion on the default "recursiveness" setting. Are
> > you suggesting to put "&recursive=0" to current URLs so that the default
> > view is recursive and the meaning of the URLs remains the same once
> > recursive diff is introduced?
> > 
> > As to link formatting, my concern is that recursive diff may be quite
> > large (e.g. if performed on a large check-in at the top-of-project
> > directory). Setting it out as a separate option in parentheses is, to
> > some extent, a mild warning, sort of "do-you-really-want-it". It also
> > makes it easier for templates to disable such links conditionally.
> 
> No concerns here whatsoever about the proposed link formatting.  I'll note,
> though, that ViewVC templates can't disable functionality -- they can
> merely obscure it.  If a fully recursive directory diff comes into being,
> we'll need viewvc.conf configury to allow/disallow it.

I understand that viewvc.py would need to check if recursive diff is allowed. 
What I meant by "disabling" was avoiding generation of the text for the link.

> And maybe I'm beginning to answer my own question here.  Maybe what's
> needed is not "&recursive=0" or "&recursive=1", but to go ahead and
> preserve your existing change (that is, non-recursive dir diffs by
> default), and then if/when we can do a recursive diff, we assign that
> functionality to a new view specifier ("view=deepdiff", for example)
> instead of today's
> "view=diff".  That gives admins a better "cognitive hook" for that
> functionality, and allows us to add "deepdiff" (or whatever we call the new
> view) to the allowed_views configuration option.

I am not sure if a separate view is needed; I think most of the machinery in 
view_diff() would be reused. As far as I understand, people usually don't type 
ViewVC URLs manually. That means, as longs as the URL stays valid and has the 
same meaning - what's wrong with adding "&recursive=1" once it's supported? 
After all, recursive diff would be a new feature - so there is no URL 
compatibility issue with it.

Regards,
Alexey.

------------------------------------------------------
http://viewvc.tigris.org/ds/viewMessage.do?dsForumId=4251&dsMessageId=2857871

To unsubscribe from this discussion, e-mail: [[email protected]].