Re: [viewvc-dev] [PATCH] WSGI server: Attribute error with pathrev URL

On 10/07/2011 08:04 AM, Ennio Zarlenga wrote:
> This is the same as issue #454 (AttributeError exception trying to escape non-string input), but for WSGI server.
> 
> Side question: why does WSGI use cgi.escape() instead of sapi.escape() ?

I think this was just something that was overlooked.

We should be able to remove the 'escape' method from WsgiServer altogether,
allowing it to inherit the same from the Server class (which already does
the right thing).  In fact, this appears to already be how things work on
the trunk codebase.  Not sure why the 1.1.x code line still carries the old
cgi.escape()-using logic.

Ah, I see what happened.  The WSGI support in 1.1.x was backported from
trunk *after* the other cgi.escape() instances were struck from the codebase.

This should be fixed in r2630.

-- 
C. Michael Pilato <[email protected]>
CollabNet   <>   www.collab.net   <>   Distributed Development On Demand

------------------------------------------------------
http://viewvc.tigris.org/ds/viewMessage.do?dsForumId=4251&dsMessageId=2857881

To unsubscribe from this discussion, e-mail: [[email protected]].

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)

iEYEARECAAYFAk6ciq0ACgkQokEGqRcG/W45ugCfR0L08VI5YcV1b79DRMZHbzvy
Hz0An3Z4L0EOXTtfvM58lp8eOu8o5L/D
=28cw
-----END PGP SIGNATURE-----