Re: [viewvc-dev] r2674 (Fix annotate views using urllib.pathname2url) breaks annotate on windows

------=_Part_3058_1544343148.1325887350969
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: quoted-printable

On 01/06/2012 04:46 PM, Jens Peters wrote:
> On 6-1-2012 22:35, C. Michael Pilato wrote:
>> On 01/06/2012 04:32 PM, C. Michael Pilato wrote:
>>> On 01/06/2012 03:23 PM, Jens Peters wrote:
>>>> Original version:
>>>> ->  rootpath    str: D:\\var\\svn\\repos\\misc
>>>>
>>>> drive, rootpath =3D os.path.splitdrive(rootpath)
>>>> ->  drive    str: D:
>>>> ->  rootpath    str: \\var\\svn\\repos\\misc
>>>>
>>>> rootpath =3D os.path.abspath(rootpath)
>>>> ->  rootpath    str: D:\\var\\svn\\repos\\misc
>>> Aha!  I was trying to reproduce this on Linux using the ntpath module
>>> directly, but forgot that even using that module, I'll never see the
>>> re-addition of a drive letter from .abspath() like you would on a real
>>> Windows system.
>>>
>>> I'll commit your fix ASAP.
>> DONE:
>>
>>     Sending        lib/vclib/svn/svn_repos.py
>>     Transmitting file data .
>>     Committed revision 2714.
>>
>> Thanks!
>>
> Very cool! Could you please backport that one to 1.1 as well?
>=20
> Regards,
> Jens

Done, along with the code that asserts that rootpaths are absolute.  (Which=
,
with my luck, will fail on your system.)

--=20
C. Michael Pilato <[email protected]>
CollabNet   <>   www.collab.net   <>   Distributed Development On Demand

------------------------------------------------------
http://viewvc.tigris.org/ds/viewMessage.do?dsForumId=3D4251&dsMessageId=3D2=
906641

To unsubscribe from this discussion, e-mail: [[email protected]=
.org].
------=_Part_3058_1544343148.1325887350969
Content-Type: application/pgp-signature; name=signature.asc
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment; filename=signature.asc
Content-Description: OpenPGP digital signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)

iEYEARECAAYFAk8Hb2MACgkQokEGqRcG/W69TACgxhlET/Ecn1rIHkiY0IiNoO7P
QIAAn3yUxsFO8Br7QAXwHTDjMYaKyMrN
=4FAP
-----END PGP SIGNATURE-----

------=_Part_3058_1544343148.1325887350969--